New strings for PR#2543

[dannycolin]

Please do not merge yet. Waiting on mozilla/multi-account-containers#2543 to get merged in the main repository.

[flodolo]

Could you provide a screenshot of where these strings are used?

[dannycolin]

They're used in Manage Extension Shortcut.

[flodolo]

Thanks. I see Container Shorcut in the string, but Contain Shortcut X (with X being a number) in the screenshot. Is that the same string concatenated to a number? 🤔

[dannycolin]

Is that the same string concatenated to a number?

Yes. AFAIK, it isn't possible to have a string with a placeholder for strings we want to translate in manifest.json.

[flodolo]

Can these strings be moved out of manifest.json in any way? That's a poor approach for localization.

[dannycolin]

Can these strings be moved out of manifest.json in any way? That's a poor approach for localization.

I haven't tested but it might be possible to use a combinaison of browser.runtime.onStartup() and browser.commands.update(). It looks a bit like a hackaround to me but it might be an acceptable compromise.

[flodolo]

Couple of nits on the comment, but strings look good. Thanks for removing the hard-coded bits.

[dannycolin]

On Luke's suggestion, @flodolo can you merge this PR before we merge multi-account-containers#2543 please?