This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
Support React #10
Merged
Support React #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For testing out our Project board: I believe this fixes #8 |
|
devinreams
reviewed
Jul 12, 2017
| @@ -5,8 +5,9 @@ | |||
| <html> | |||
| <head> | |||
| <title>Lockbox</title> | |||
| <script src="chrome://lockbox/content/aboutPage.js" defer></script> | |||
There was a problem hiding this comment.
Now that this is back to about:lockbox, is this path correct?
There was a problem hiding this comment.
Follow-up: yes, it is. I just need to run webpack to actually get this asset in the right place.
linuxwolf
reviewed
Jul 12, 2017
package.json
Outdated
| "scripts": { | ||
| "run": "jpm run", | ||
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, |
There was a problem hiding this comment.
There should be an entry for running webpack here, e.g.:
"build": "webpack"
| /lockbox-*.xpi | ||
| /site | ||
| /dist/chrome/content/aboutPage.js |
linuxwolf
approved these changes
Jul 12, 2017
|
|
kimberlythegeek
pushed a commit
to kimberlythegeek/lockbox-extension
that referenced
this pull request
Mar 21, 2018
# This is the 1st commit message: Update flake8-isort from 2.2.2 to 2.4 (mozilla-lockwise#587) # This is the commit message mozilla-lockwise#2: Update pytest from 3.3.1 to 3.4.1 (mozilla-lockwise#589) # This is the commit message mozilla-lockwise#3: Update pytest-selenium from 1.11.3 to 1.11.4 (mozilla-lockwise#590) # This is the commit message mozilla-lockwise#4: Update pypom from 1.2.0 to 1.3.0 (mozilla-lockwise#594) # This is the commit message mozilla-lockwise#5: Update selenium from 3.8.0 to 3.9.0 (mozilla-lockwise#592) # This is the commit message mozilla-lockwise#6: Update pytest-xdist from 1.20.1 to 1.22.2 (mozilla-lockwise#591) # This is the commit message mozilla-lockwise#7: Update flake8-docstrings from 1.1.0 to 1.3.0 (mozilla-lockwise#588) # This is the commit message mozilla-lockwise#8: More account dropdown style updates (mozilla-lockwise#597) * Styling updates based off Jim's code review of mozilla-lockwise#549 -Updated pseudo-elements to have two colons instead of one -Moved toolbar margin update to be specific to navigation bar -Removed arrowhead down icon that is no longer in use -Updated dropdown hover, focus and active states after reviewing how Firefox browser handles similar items * Updating toolbar to use px instead of ch to be consistent. # This is the commit message mozilla-lockwise#9: Include whitespace in item fields so new lines are output (mozilla-lockwise#596) * Include whitespace in item fields so new lines are output * move white-space to all input text fields # This is the commit message mozilla-lockwise#10: Automatically focus the filter input when the page loads; resolves mozilla-lockwise#573 # This is the commit message mozilla-lockwise#11: Styling updates around entry list items (mozilla-lockwise#553) * Styling updates around entry list items -Active and focus states -Increased padding to match mocks -New chevron icon -Updated aside background color -Moved border between search and entries in order to apply active border color to top entry item -Small copy change to empty state * Changes based off PR feedback -Removed arrowhead right icon that is no longer used -Removed some styling around border between filter and list items until we get the filter updated. * Add custom "no username" instruction text when adding entry * Remove string interpolation and use better const name * Ran cheveron-right through svgo, sizing was also updated.
kimberlythegeek
added a commit
to kimberlythegeek/lockbox-extension
that referenced
this pull request
Mar 21, 2018
# This is the 1st commit message: # This is a combination of 2 commits. # This is the 1st commit message: # This is a combination of 3 commits. # This is the 1st commit message: # This is a combination of 9 commits. # This is the 1st commit message: # This is a combination of 15 commits. # This is the 1st commit message: # This is a combination of 49 commits. # This is the 1st commit message: # This is a combination of 2 commits. # This is the 1st commit message: # This is a combination of 25 commits. # This is the 1st commit message: flake8 # This is the commit message mozilla-lockwise#2: Refresh OAuth Access Tokens (mozilla-lockwise#547) # This is the commit message mozilla-lockwise#3: Styling adjustments for the account dropdown. (mozilla-lockwise#549) # This is the commit message mozilla-lockwise#4: Update Version and Release Notes to 0.1.7-alpha (mozilla-lockwise#558) # This is the commit message mozilla-lockwise#5: chore(package): update eslint-plugin-no-unsanitized to version 3.0.0 (mozilla-lockwise#537) # This is the commit message mozilla-lockwise#6: chore(package): update mocha to version 5.0.1 (mozilla-lockwise#544) # This is the commit message mozilla-lockwise#7: chore(package): update stylelint to version 9.1.1 (mozilla-lockwise#566) # This is the commit message mozilla-lockwise#8: chore(package): update stylelint-config-recommended to version 2.1.0 (mozilla-lockwise#551) # This is the commit message mozilla-lockwise#9: Add Support For Telemetry Scalars; Update Metrics.md (mozilla-lockwise#552) # This is the commit message mozilla-lockwise#10: Provide documentation about how to post PRs (mozilla-lockwise#507) # This is the commit message mozilla-lockwise#11: Ensure FxA account is stored always (mozilla-lockwise#570) # This is the commit message mozilla-lockwise#12: Update Version and Release Notes to 0.1.7-alpha1 (mozilla-lockwise#571) # This is the commit message mozilla-lockwise#13: Updated text color of entry list empty state for better contrast (mozilla-lockwise#560) # This is the commit message mozilla-lockwise#14: Add config file for pyup.io to update weekly (mozilla-lockwise#586) * create pyup.io config file * update all dependencies, not just security * remove extra whitespace # This is the commit message mozilla-lockwise#15: Update flake8-isort from 2.2.2 to 2.4 (mozilla-lockwise#587) # This is the commit message mozilla-lockwise#16: Update pytest from 3.3.1 to 3.4.1 (mozilla-lockwise#589) # This is the commit message mozilla-lockwise#17: Update pytest-selenium from 1.11.3 to 1.11.4 (mozilla-lockwise#590) # This is the commit message mozilla-lockwise#18: Update pypom from 1.2.0 to 1.3.0 (mozilla-lockwise#594) # This is the commit message mozilla-lockwise#19: Update selenium from 3.8.0 to 3.9.0 (mozilla-lockwise#592) # This is the commit message mozilla-lockwise#20: Update pytest-xdist from 1.20.1 to 1.22.2 (mozilla-lockwise#591) # This is the commit message mozilla-lockwise#21: Update flake8-docstrings from 1.1.0 to 1.3.0 (mozilla-lockwise#588) # This is the commit message mozilla-lockwise#22: More account dropdown style updates (mozilla-lockwise#597) * Styling updates based off Jim's code review of mozilla-lockwise#549 -Updated pseudo-elements to have two colons instead of one -Moved toolbar margin update to be specific to navigation bar -Removed arrowhead down icon that is no longer in use -Updated dropdown hover, focus and active states after reviewing how Firefox browser handles similar items * Updating toolbar to use px instead of ch to be consistent. # This is the commit message mozilla-lockwise#23: Include whitespace in item fields so new lines are output (mozilla-lockwise#596) * Include whitespace in item fields so new lines are output * move white-space to all input text fields # This is the commit message mozilla-lockwise#24: Automatically focus the filter input when the page loads; resolves mozilla-lockwise#573 # This is the commit message mozilla-lockwise#25: Styling updates around entry list items (mozilla-lockwise#553) * Styling updates around entry list items -Active and focus states -Increased padding to match mocks -New chevron icon -Updated aside background color -Moved border between search and entries in order to apply active border color to top entry item -Small copy change to empty state * Changes based off PR feedback -Removed arrowhead right icon that is no longer used -Removed some styling around border between filter and list items until we get the filter updated. * Add custom "no username" instruction text when adding entry * Remove string interpolation and use better const name * Ran cheveron-right through svgo, sizing was also updated. # This is the commit message mozilla-lockwise#2: 0.1.7-alpha1 (mozilla-lockwise#574) # This is the commit message mozilla-lockwise#2: Updating styling of 0 entries (home) page to reflect intended typography and spacing (mozilla-lockwise#607) - Into image shadow to Shadow 10 - Updated image border - Defined line height for intro paragraphs # This is the commit message mozilla-lockwise#3: Create a <PanelFooterButton/> and update the styles for the unlock do… (mozilla-lockwise#601) * Create a <PanelFooterButton/> and update the styles for the unlock doorhanger; resolves mozilla-lockwise#482 * latest Nessie with darker waves # This is the commit message mozilla-lockwise#4: Update selenium from 3.9.0 to 3.10.0 # This is the commit message mozilla-lockwise#5: chore(package): update documentation to version 6.0.0 # This is the commit message mozilla-lockwise#6: Require python 3.6 in deploy stage so pip can install tornado # This is the commit message mozilla-lockwise#7: Create/Edit Entry Details Styling Adjustments (mozilla-lockwise#567) * Styling adjustments for entry details -Added show/hide icons for password -Reordered fields to match new designs -Removed monospace class from username field -Fixed sizing/spacing to match designs -Updated to use box-sizing: border box, and fixed issues this caused in other areas -Updated placeholder copy and labels to match design changes -Added min-width to buttons * Adding min-width to normal button style and larger min-width for primary buttons * Styling for dialog box and adding new critical/red button style * Changes based on PR review -ran svgo on show icon to optimize -created new notes class in entry details for styling -removed box sizing and associated style changes -moved password styles to input.css -Removed show/hide button text and keys -Changed critical theme to danger theme -Reverted dialog to use primary button by default * Re-localize the show/hide password input buttons * Fix input tests to also check for first "input" class * Better RegEx for munged password input class tests * Fixing missed styles from box-sizing removal that needed updated * Provide the option of using "danger" buttons in dialog boxes These are currently used in two places: * Deleting items * Resetting the datastore * restore indentation * Fixes based on PR changes requested -Ran show icon through svgo -Moved input max-width for entry creation/edition fields to item-fields.css -Created new "wide" button sub-theme for instances to include min-width property -Added size theme to save/edit button on entry details * Adding .input class to item fields for styling and removing unnecessary selector # This is the commit message mozilla-lockwise#8: Improvements to search bar styling in full manage mode (mozilla-lockwise#562) * Styling adjustments for entry list filter. -Added search icon -Updated padding/colors -Included clear icon but needs implemented -Removed "entries" from placeholder copy * Styling updates for entries list filter in aside -Fixed padding/sizing to match design -Added search icon -Replaced text link with 'clear icon' -Updated placeholder copy to 'search lockbox' * Changes after review with Ryan -Darkening placeholder text -Updated border radius on inputs -Reverting search to use regular weight * Moving location of styles for filter/search in order to cover both doorhanger and full page view * Adding MPL-2.0 license to item-filter file and new line on app.css * Updates based on PR feedback -Added new line at end of SVG files -Removed item-filter.css and moved styles to input.css file -Wrapped filter in <toolbar> element and applied padding there -Added title attribute to clear button * Removing "clear" text from filter button * Update input test regex to include first input filter class * Restore localization of "Clear" text on search * Better RegEx for munged input class tests * Removed some unnecessary styles left behind and updated padding for consistency. * Ran clear and search svgs through svgo * Restore filter styles lost in master branch merge 28e31d5 # This is the commit message mozilla-lockwise#9: Make sure options_ui is fully displayed on about:addons (mozilla-lockwise#603) * Make sure options_ui is fully displayed on about:addons * flex-direction is actually not necessary, not sure why i ended up with it * add margin so button focus state fits and text aligns with items above * add min-height to give the warning dialog more room to breathe # This is the commit message mozilla-lockwise#10: added accessibility test plan to docs # This is the commit message mozilla-lockwise#11: Attempt to speed up branch and PR builds with Travis CI caching (mozilla-lockwise#604) * Speed up branch and PR builds with Travis CI caching * add pip cache # This is the commit message mozilla-lockwise#12: writing jenkins config # This is the commit message mozilla-lockwise#13: fixed typo # This is the commit message mozilla-lockwise#14: edited jenkins config # This is the commit message mozilla-lockwise#15: edited jenkins config # This is the commit message mozilla-lockwise#16: edited jenkins config # This is the commit message mozilla-lockwise#17: edited jenkins config # This is the commit message mozilla-lockwise#18: edited jenkins config # This is the commit message mozilla-lockwise#19: edited jenkins config # This is the commit message mozilla-lockwise#20: edited jenkins config # This is the commit message mozilla-lockwise#21: edited jenkins config # This is the commit message mozilla-lockwise#22: edited jenkins config # This is the commit message mozilla-lockwise#23: edited jenkins config # This is the commit message mozilla-lockwise#24: edited jenkins config # This is the commit message mozilla-lockwise#25: added jenkins build script # This is the commit message mozilla-lockwise#26: edited jenkins config # This is the commit message mozilla-lockwise#27: edited jenkins config # This is the commit message mozilla-lockwise#28: edited jenkins config # This is the commit message mozilla-lockwise#29: edited jenkins config # This is the commit message mozilla-lockwise#30: edited jenkins config # This is the commit message mozilla-lockwise#31: edited jenkins config # This is the commit message mozilla-lockwise#32: edited jenkins config # This is the commit message mozilla-lockwise#33: edited jenkins config # This is the commit message mozilla-lockwise#34: edited jenkins config # This is the commit message mozilla-lockwise#35: including a11y tests # This is the commit message mozilla-lockwise#36: flake8 # This is the commit message mozilla-lockwise#37: flake8 # This is the commit message mozilla-lockwise#38: removed pypom from test reqs # This is the commit message mozilla-lockwise#39: edited jenkins config # This is the commit message mozilla-lockwise#40: edited jenkins config # This is the commit message mozilla-lockwise#41: edited jenkins config # This is the commit message mozilla-lockwise#42: edited jenkins config # This is the commit message mozilla-lockwise#43: edited jenkins config # This is the commit message mozilla-lockwise#44: Styling adjustment to align entry detail buttons during edit and view mode change (mozilla-lockwise#608) # This is the commit message mozilla-lockwise#45: Fix <ItemFilter/> to actually update its state from Redux # This is the commit message mozilla-lockwise#46: Fix importing of chai-enzyme in <ButtonStack/> test # This is the commit message mozilla-lockwise#47: Automatically select the filter input's text on load (if there is any) # This is the commit message mozilla-lockwise#48: Pre-fill the URL of the current tab into the doorhanger's filter # This is the commit message mozilla-lockwise#49: Prepare 0.1.8 release (mozilla-lockwise#612) * bump version numbers to 0.1.8-alpha * draft release notes based on current progress and fixed release note headings in previous release * recent additions for release notes * last items included in this release * remove depdencies updates from release notes # This is the commit message mozilla-lockwise#2: Fix the color of the horizontal line in the item details of the manager # This is the commit message mozilla-lockwise#3: edited jenkins config # This is the commit message mozilla-lockwise#4: edited jenkins config # This is the commit message mozilla-lockwise#5: edited jenkins config # This is the commit message mozilla-lockwise#6: edited jenkins config # This is the commit message mozilla-lockwise#7: edited jenkins config # This is the commit message mozilla-lockwise#8: edited jenkins config # This is the commit message mozilla-lockwise#9: edited jenkins config # This is the commit message mozilla-lockwise#10: edited jenkins config # This is the commit message mozilla-lockwise#11: edited jenkins config # This is the commit message mozilla-lockwise#12: edited jenkins config # This is the commit message mozilla-lockwise#13: edited jenkins config # This is the commit message mozilla-lockwise#14: Move python runtime for deploy stage out of 'on' requirement So the pages actually build using python 3.6 instead of just checking to make sure its in the 3.6 runtime # This is the commit message mozilla-lockwise#15: Downgrade Travis deploy script to fix pages deploy See travis-ci/travis-ci#9312 # This is the commit message mozilla-lockwise#2: Improve implementation of <Stack/> (formerly <ButtonStack/>) Unfortunately, to have behavior like <xul:deck>, the only way I can figure out is just to use the XUL box model. :( # This is the commit message mozilla-lockwise#3: Allow greater customization of <CopyToClipboardButton/> # This is the commit message mozilla-lockwise#4: Provide visuals for the quick-copy buttons in the doorhanger list view # This is the commit message mozilla-lockwise#5: Add support for copying the username and password from the quick-copy buttons # This is the commit message mozilla-lockwise#6: Add telemetry for the quick-copy buttons # This is the commit message mozilla-lockwise#7: Address styling concerns # This is the commit message mozilla-lockwise#8: Add tests for quick-copy behavior # This is the commit message mozilla-lockwise#9: Address mozilla-lockwise#570 Post-Merge Code Review Comments (mozilla-lockwise#647) # This is the commit message mozilla-lockwise#2: changes to metrics # This is the commit message mozilla-lockwise#3: Update stylelint to the latest version 🚀 (mozilla-lockwise#658) * chore(package): update stylelint to version 9.1.2 * chore(package): update stylelint to version 9.1.3 # This is the commit message mozilla-lockwise#2: Update flake8-isort from 2.4 to 2.5 (mozilla-lockwise#671) # This is the commit message mozilla-lockwise#2: Docs are wrong becuase sync is not currently supported fixes mozilla-lockwise#670
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for React and building via WebPack. We should probably decide what (if anything) to do with the Makefile, since there's now a build step that needs to run. Also, I'd really like it if we had a better way of managing non-WebPacked files (i.e. the stuff in
dist/), since I hate having to cram the build artifacts in there and add them to .gitignore. I'd much prefer out-of-tree builds.