This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
Ensure Lock screen clears the back stack #143
Comments
jhugman
added a commit
that referenced
this issue
Oct 19, 2018
…ck stack (#156) r=sasha Fixes #143 This PR re-implements detecting the menu item selections to use the dispatcher to call the `navController`. This is because the blessed way of using the appDrawer with the navController constructed its own action (and animations) instead of using the one we specifiy in the `graph.xml`. This adds those default animations to the settings action, and changes the action to the locked screen to clear the back stack. Additionally, the locked screen is moved to its own subgraph. Unfortunately, the action to transition to the locked screen can't be made into a global action yet, due to a bug in the navigation library. * Move fragment_locked to a subgraph * Recreate how menu items use the nav controller, but allow for our own actions. * Rename nav_graph to graph_main because we're going to have multiple graphs. * Code reorganize of `RoutePresenter`, without code changes. * Removed `action_itemList_to_*` from UI and presenter code.
ghost
removed
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As a followup to PR #133, this story ensures that no portion of the app is navigatable to from the lock screen, except by pressing the "Unlock" button — or if it has been implemented, by unlocking it.
This may mean separating the lockscreen off into its own navigation graph, or activity.
Acceptance criteria:
The text was updated successfully, but these errors were encountered: