Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Minor UI changes for item detail toast and learn more link colors #272

Merged
merged 5 commits into from
Dec 17, 2018

Conversation

devinreams
Copy link
Contributor

Fixes #267

Also starts but doesn't finish #262 - I just wanted to get sane colors in place for testing/usability, will wait to see what the final view/result built at #232 ends up so we can easily re-use

Testing and Review Notes

  • open app
  • open item detail
  • observe the background color of the text link at the bottom matches the screen (grey, not white)
  • tap copy button on username/password, observe the white on grey colors of the toast

Screenshots or Videos

screen shot 2018-12-13 at 8 35 33 am

screen shot 2018-12-13 at 8 35 23 am

To Do

  • add “WIP” to the PR title if pushing up but not complete nor ready for review
  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • add unit tests
  • consider running this branch in a debug simulator and check for memory leak notifications or any warnings
  • request the "UX" team perform a design review (if/when applicable)
  • make sure CI builds are passing (e.g.: fix lint and other errors)
  • check on the accessibility of any added UI

related to but doesn't complete #262
will wait on view and styles built at #232 for reuse
@devinreams devinreams self-assigned this Dec 13, 2018
@devinreams devinreams requested a review from a team December 13, 2018 15:49
@devinreams devinreams requested a review from a team as a code owner December 13, 2018 15:49
@ghost ghost added the in progress label Dec 13, 2018
Copy link
Contributor

@sashei sashei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; I'm sure you'll want a design review as well :)

app/src/main/res/layout/fragment_item_detail.xml Outdated Show resolved Hide resolved
@devinreams
Copy link
Contributor Author

Waiting to merge after #232 is closed and a successful rebase/merge from master is completed...

@devinreams devinreams mentioned this pull request Dec 17, 2018
6 tasks
@devinreams devinreams merged commit 7d2f13e into master Dec 17, 2018
@ghost ghost removed the in progress label Dec 17, 2018
@devinreams devinreams deleted the minor-ui-tweaks branch December 17, 2018 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove white background on “Learn how to edit this entry” link on Entry Detail
3 participants