1.3 (Build 2362)

mozilla-lockwise · Sep 15, 2018 · ab5317c · ab5317c
2 parents 34ab2be + 36cce44
commit ab5317c
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 10 deletions.
diff --git a/docs/release-notes.md b/docs/release-notes.md
@@ -1,19 +1,33 @@
 # Release Notes
 
+## 1.3 (Build 2349)
+
+_Date: 2018-09-14_
+
+With iOS 12 you can automatically fill your usernames and passwords from Firefox Lockbox into apps and websites.
+
+Be sure to enable AutoFill after updating to iOS 12 from within Settings under the "Passwords & Accounts" section.
+
 ## 1.3 (Build 2340)
 
+_Date: 2018-09-14_
+
 With iOS 12 you can automatically fill your usernames and passwords from Firefox Lockbox into apps and websites.
 
 Be sure to enable AutoFill after updating to iOS 12 from within Settings under the "Passwords & Accounts" section.
 
 ## 1.3 (Build 2320)
 
+_Date: 2018-09-14_
+
 With iOS 12 you can automatically fill your usernames and passwords from Firefox Lockbox into apps and websites.
 
 Be sure to enable AutoFill after updating to iOS 12 from within Settings under the "Passwords & Accounts" section.
 
 ## 1.3 (Build 2294)
 
+_Date: 2018-09-13_
+
 With iOS 12 you can automatically fill your usernames and passwords from Firefox Lockbox into apps and websites.
 
 Be sure to enable AutoFill after updating to iOS 12 from within Settings under the "Passwords & Accounts" section.

diff --git a/lockbox-ios/Action/ExternalLinkAction.swift b/lockbox-ios/Action/ExternalLinkAction.swift
@@ -15,13 +15,6 @@ struct ExternalLinkAction: LinkAction {
 enum SettingLinkAction: RouteAction {
     case touchIDPasscode
     case autofill
-
-    func toString() -> String {
-        switch self {
-        case .touchIDPasscode: return "App-Prefs:root=TOUCHID_PASSCODE"
-        case .autofill: return "App-Prefs:root=Passwords_And_Accounts"
-        }
-    }
 }
 
 extension ExternalLinkAction: Equatable {

diff --git a/lockbox-ios/Store/ExternalLinkStore.swift b/lockbox-ios/Store/ExternalLinkStore.swift
@@ -45,7 +45,7 @@ class ExternalLinkStore {
     }
 
     private func openSettings(_ action: SettingLinkAction) {
-        if let settingsURL = URL(string: action.toString()),
+        if let settingsURL = URL(string: UIApplication.openSettingsURLString),
             self.application.canOpenURL(settingsURL) {
             self.application.open(settingsURL, options: [:], completionHandler: nil)
         }

diff --git a/lockbox-iosTests/ExternalLinkStoreSpec.swift b/lockbox-iosTests/ExternalLinkStoreSpec.swift
@@ -63,7 +63,7 @@ class ExternalLinkStoreSpec: QuickSpec {
                 }
 
                 it("opens the appropriate string value of the settings page") {
-                    let expectedURL = URL(string: "App-Prefs:root=TOUCHID_PASSCODE")
+                    let expectedURL = URL(string: UIApplication.openSettingsURLString)
                     expect(self.application.canOpenURLArgument).to(equal(expectedURL))
                     expect(self.application.openArgument).to(equal(expectedURL))
                 }
@@ -75,7 +75,7 @@ class ExternalLinkStoreSpec: QuickSpec {
                 }
 
                 it("opens the appropriate string value of the settings page") {
-                    let expectedURL = URL(string: "App-Prefs:root=Passwords_And_Accounts")
+                    let expectedURL = URL(string: UIApplication.openSettingsURLString)
                     expect(self.application.canOpenURLArgument).to(equal(expectedURL))
                     expect(self.application.openArgument).to(equal(expectedURL))
                 }