Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Audit error handling + non-crash-related Sentry reporting #1017

Closed
3 tasks done
sashei opened this issue May 24, 2019 · 0 comments · Fixed by #1038
Closed
3 tasks done

Audit error handling + non-crash-related Sentry reporting #1017

sashei opened this issue May 24, 2019 · 0 comments · Fixed by #1038
Assignees
@sashei
Labels
priority-P2 task Issue describes a task that needs to be completed but is not a defect or enhancement in itself.
Projects
Lockwise Mobile
Milestone
1.6.2 - Stability

Comments

@sashei
Copy link
Contributor

sashei commented May 24, 2019 •
edited

Acceptance criteria

  • All do...catch blocks have a more explicit handler than print
  • DataStoreState.Errored is handled in a meaningful way
  • Explicit & meaningful error information is extracted into a SentryAction where possible.
@sashei sashei added the task Issue describes a task that needs to be completed but is not a defect or enhancement in itself. label May 24, 2019
@sashei sashei added this to On Deck in Lockwise Mobile via automation May 24, 2019
@sashei sashei moved this from On Deck to In Progress in Lockwise Mobile May 31, 2019
@sashei sashei mentioned this issue May 31, 2019
Merged
3 tasks
@devinreams devinreams added this to the 1.6.2 - Stability milestone Jun 6, 2019
Lockwise Mobile automation moved this from In Progress to Done Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sashei sashei

Labels
priority-P2 task Issue describes a task that needs to be completed but is not a defect or enhancement in itself.
Projects
Lockwise Mobile
  
Done
Milestone
1.6.2 - Stability
Development

Successfully merging a pull request may close this issue.

error improvements mozilla-lockwise/lockwise-ios
2 participants
@devinreams @sashei