Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

error improvements #1038

Merged
merged 6 commits into from Jun 11, 2019
Merged

error improvements #1038

merged 6 commits into from Jun 11, 2019

Conversation

sashei
Copy link
Contributor

@sashei sashei commented May 31, 2019 •
edited

Fixes #1017

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • make sure CI builds are passing (e.g.: fix lint and other errors)

@sashei sashei requested a review from a team as a code owner May 31, 2019 22:07
linuxwolf
linuxwolf approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@linuxwolf linuxwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

LGTM

@devinreams devinreams merged commit b6f9332 into master Jun 11, 2019
@devinreams devinreams deleted the 1017-error-improvements branch June 11, 2019 17:16
devinreams added a commit that referenced this pull request Jun 11, 2019
@devinreams
Revert "improved error handling (#1038)"
db88cec 
This reverts commit b6f9332.
@devinreams devinreams mentioned this pull request Jun 11, 2019
Closed
@devinreams devinreams restored the 1017-error-improvements branch June 11, 2019 17:47
@devinreams devinreams deleted the 1017-error-improvements branch June 11, 2019 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@linuxwolf linuxwolf linuxwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit error handling + non-crash-related Sentry reporting
3 participants
@sashei @linuxwolf @devinreams