Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

update a-s #1019

Merged
merged 1 commit into from May 28, 2019
Merged

update a-s #1019

merged 1 commit into from May 28, 2019

Conversation

sashei
Copy link
Contributor

@sashei sashei commented May 28, 2019 •
edited

Fixes #1013

Testing and Review Notes

I did some basic smoke tests locally (signed in, locked, autofilled, etc)

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • make sure CI builds are passing (e.g.: fix lint and other errors)

@sashei sashei requested a review from a team as a code owner May 28, 2019 14:45
devinreams
devinreams approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@devinreams devinreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgraded from 1.6.0 to this build and it kept me signed in, unlocked OK, and disconnect/reconnect also worked as expected on iPhone XS. 👍

I've not experienced sign in / sync issues myself though so want to merge and then bump app version to get this on TestFlight ASAP.

@devinreams devinreams merged commit 4871e5e into master May 28, 2019
@devinreams devinreams deleted the 1013-a-s-update branch May 28, 2019 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devinreams devinreams devinreams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to latest version of Application Services
2 participants
@sashei @devinreams