Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

migrate to Swift 5 #1037

Merged
merged 3 commits into from Jun 3, 2019
Merged

migrate to Swift 5 #1037

merged 3 commits into from Jun 3, 2019

Conversation

sashei
Copy link
Contributor

@sashei sashei commented May 31, 2019

Fixes #945

To Do

  • make sure CI builds are passing (e.g.: fix lint and other errors)

@sashei sashei requested a review from a team as a code owner May 31, 2019 16:37
devinreams
devinreams approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@devinreams devinreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked on my machine after a carthage bootstrap (to make sure it got RxRelay).

UI test just failing again due to changed/missing test data entry, right? 🙃

@sashei
Copy link
Contributor Author

sashei commented Jun 3, 2019

@devinreams yep that's the only reason it's failing :(

@sashei sashei merged commit 7b918b7 into master Jun 3, 2019
@sashei sashei deleted the 945-swift-5 branch June 3, 2019 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devinreams devinreams devinreams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to Swift 5.0.1
2 participants
@sashei @devinreams