This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Closes #8681: Do not retry to update an extension when an unrecoverab…
…le exception happens
- Loading branch information
1 parent
b78b41f
commit 6883c17
Showing
15 changed files
with
355 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
...n/java/mozilla/components/browser/engine/gecko/webextension/GeckoWebExtensionException.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
||
package mozilla.components.browser.engine.gecko.webextension | ||
|
||
import mozilla.components.concept.engine.webextension.WebExtensionException | ||
import org.mozilla.geckoview.WebExtension.InstallException | ||
import org.mozilla.geckoview.WebExtension.InstallException.ErrorCodes.ERROR_USER_CANCELED | ||
|
||
/** | ||
* An unexpected gecko exception that occurs when trying to perform an action on the extension like | ||
* (but not exclusively) installing/uninstalling, removing or updating. | ||
*/ | ||
class GeckoWebExtensionException(throwable: Throwable) : WebExtensionException(throwable) { | ||
override val isRecoverable: Boolean = throwable is InstallException && | ||
throwable.code == ERROR_USER_CANCELED | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
...n/java/mozilla/components/browser/engine/gecko/webextension/GeckoWebExtensionException.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
||
package mozilla.components.browser.engine.gecko.webextension | ||
|
||
import mozilla.components.concept.engine.webextension.WebExtensionException | ||
import org.mozilla.geckoview.WebExtension.InstallException | ||
import org.mozilla.geckoview.WebExtension.InstallException.ErrorCodes.ERROR_USER_CANCELED | ||
|
||
/** | ||
* An unexpected gecko exception that occurs when trying to perform an action on the extension like | ||
* (but not exclusively) installing/uninstalling, removing or updating.. | ||
*/ | ||
class GeckoWebExtensionException(throwable: Throwable) : WebExtensionException(throwable) { | ||
override val isRecoverable: Boolean = throwable is InstallException && | ||
throwable.code == ERROR_USER_CANCELED | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
...n/java/mozilla/components/browser/engine/gecko/webextension/GeckoWebExtensionException.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
||
package mozilla.components.browser.engine.gecko.webextension | ||
|
||
import mozilla.components.concept.engine.webextension.WebExtensionException | ||
import org.mozilla.geckoview.WebExtension.InstallException | ||
import org.mozilla.geckoview.WebExtension.InstallException.ErrorCodes.ERROR_USER_CANCELED | ||
|
||
/** | ||
* An unexpected gecko exception that occurs when trying to perform an action on the extension like | ||
* (but not exclusively) installing/uninstalling, removing or updating. | ||
*/ | ||
class GeckoWebExtensionException(throwable: Throwable) : WebExtensionException(throwable) { | ||
override val isRecoverable: Boolean = throwable is InstallException && | ||
throwable.code == ERROR_USER_CANCELED | ||
} |
Oops, something went wrong.