Fixes #1970 - Guards the close listener

mozilla-mobile · Feb 6, 2019 · a540d32 · a540d32
1 parent 91bfcf5
commit a540d32
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/...ustomtabs/src/main/java/mozilla/components/feature/customtabs/CustomTabsToolbarFeature.kt b/...ustomtabs/src/main/java/mozilla/components/feature/customtabs/CustomTabsToolbarFeature.kt
@@ -135,10 +135,11 @@ class CustomTabsToolbarFeature(
      */
     fun onBackPressed(): Boolean {
         val result = sessionManager.runWithSession(sessionId) {
+            closeListener.invoke()
             remove(it)
             true
         }
-        closeListener.invoke()
+
         return result
     }
 

diff --git a/...mtabs/src/test/java/mozilla/components/feature/customtabs/CustomTabsToolbarFeatureTest.kt b/...mtabs/src/test/java/mozilla/components/feature/customtabs/CustomTabsToolbarFeatureTest.kt
@@ -317,10 +317,27 @@ class CustomTabsToolbarFeatureTest {
         `when`(sessionManager.findSessionById(anyString())).thenReturn(session)
 
         val feature = spy(CustomTabsToolbarFeature(sessionManager, toolbar, sessionId) { closeExecuted = true })
-
         val result = feature.onBackPressed()
 
         assertTrue(result)
         assertTrue(closeExecuted)
     }
+
+    @Test
+    fun `onBackPressed without a session does nothing`() {
+        val sessionId = null
+        val session: Session = mock()
+        val toolbar = BrowserToolbar(RuntimeEnvironment.application)
+        val sessionManager: SessionManager = mock()
+        var closeExecuted = false
+        `when`(session.customTabConfig).thenReturn(mock())
+        `when`(sessionManager.findSessionById(anyString())).thenReturn(session)
+
+        val feature = spy(CustomTabsToolbarFeature(sessionManager, toolbar, sessionId) { closeExecuted = true })
+
+        val result = feature.onBackPressed()
+
+        assertFalse(result)
+        assertFalse(closeExecuted)
+    }
 }
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -19,6 +19,9 @@ permalink: /changelog/
 * **browser-engine-system**
   * Added support for [JavaScript prompt alerts](https://developer.mozilla.org/en-US/docs/Web/API/Window/prompt) on WebView.
 
+* **feature-customtabs**
+  * Fixed an issue causing the `closeListener` to be invoked even when the current session isn't a Custom Tab.
+
 # 0.41.0
 
 * [Commits](https://github.com/mozilla-mobile/android-components/compare/v0.40.0...v0.41.0)