Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

[Feature][Custom Tabs] Prevent onBackPressed when it's not initialized #1970

Closed
boek opened this issue Feb 6, 2019 · 2 comments
Closed

[Feature][Custom Tabs] Prevent onBackPressed when it's not initialized #1970

boek opened this issue Feb 6, 2019 · 2 comments
Labels
🐞 bug Something isn't working <customtabs> Component: feature-customtabs
Projects
A-C: Meta: Custom Tabs A-C: Android Components Sprint Planning
Milestone
0.42 🦞

Comments

@boek
Copy link
Contributor

boek commented Feb 6, 2019 •
edited by data-sync-user
Loading

Original report: mozilla-mobile/fenix#389

https://github.com/mozilla-mobile/android-components/blob/master/components/feature/customtabs/src/main/java/mozilla/components/feature/customtabs/CustomTabsToolbarFeature.kt#L137

Even in a state where we're not running in a custom tab we're calling the closeListener.

┆Issue is synchronized with this Jira Task
@boek boek mentioned this issue Feb 6, 2019
Closed
@pocmo
Copy link
Contributor

pocmo commented Feb 6, 2019

Oh yes, if this is not a CustomTab then this should be a no-op. CC @jonalmeida

@pocmo pocmo added 🐞 bug Something isn't working <customtabs> Component: feature-customtabs labels Feb 6, 2019
@pocmo pocmo added this to Backlog in A-C: Meta: Custom Tabs Feb 6, 2019
@boek
Copy link
Contributor Author

boek commented Feb 6, 2019

got a PR just about to open

boek added a commit to boek/android-components that referenced this issue Feb 6, 2019
@boek
Fixes mozilla-mobile#1970 - Guards the close listener
069b5be
boek added a commit to boek/android-components that referenced this issue Feb 6, 2019
@boek
Fixes mozilla-mobile#1970 - Guards the close listener
f7cd3c0
@pocmo pocmo added this to the 0.42 🦞 milestone Feb 6, 2019
boek added a commit to boek/android-components that referenced this issue Feb 6, 2019
@boek
Fixes mozilla-mobile#1970 - Guards the close listener
3a383af
boek added a commit to boek/android-components that referenced this issue Feb 6, 2019
@boek
Fixes mozilla-mobile#1970 - Guards the close listener
5b992e0
@pocmo pocmo closed this as completed in a540d32 Feb 6, 2019
A-C: Android Components Sprint Planning automation moved this from In Progress to Done Feb 6, 2019
A-C: Meta: Custom Tabs automation moved this from Backlog to Done Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Something isn't working <customtabs> Component: feature-customtabs
Projects
No open projects
A-C: Android Components Sprint Planning
  
🏁 Done
A-C: Meta: Custom Tabs
  
Done
Milestone
0.42 🦞
Development

No branches or pull requests
2 participants
@pocmo @boek