Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add third batch of icons #10231

Closed
29 of 32 tasks
Amejia481 opened this issue May 6, 2021 · 7 comments
Closed
29 of 32 tasks

Add third batch of icons #10231

Amejia481 opened this issue May 6, 2021 · 7 comments
Assignees
Labels
E2 Estimation points: 2
Milestone

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented May 6, 2021

See this comment mozilla-mobile/fenix#18132 (comment)

  • help
  • folder
  • folder add/new
  • share (the Android symbol is three circles connected with lines)
  • collection
  • add to home screen
  • password (eye)
  • password hide (eye with cross)
  • checkmark
  • website placeholder (this is not just used for generic website, but also for Settings menu items like “Exceptions”
  • edit
  • sync (it’s already using the right icon, just needs to point the other way – counterclockwise – and the icon has been updated to reflect that)

Permissions

  • location
  • location blocked
  • camera
  • camera blocked
  • microphone
  • microphone blocked
  • notifications
  • notifications blocked
  • storage
  • storage blocked
  • autoplay media
  • autoplay media blocked

Make sure that DRM-controlled content is using the new link icon – I think it already does?

Tracking Protection

  • cryptominer
  • fingerprinter
  • social tracker
  • third party cookies

New Tab Page

Add-ons Manager

  • rating (small - 16x16 – in Add-ons Manager)
  • rating half (small - 16x16 – in Add-ons Manager)

┆Issue is synchronized with this Jira Task

@Amejia481 Amejia481 added the E3 Estimation points: 3 label May 6, 2021
@Amejia481 Amejia481 added this to the 90.0.0 🌳 milestone May 6, 2021
@Amejia481 Amejia481 self-assigned this May 6, 2021
@brampitoyo
Copy link
Contributor

@Amejia481 Just a note before we get started: both the share and edit icons are currently being finalised. They’re due to be delivered soon. I’ll let you know as soon as they’re ready, so you can start adding them in :-)

@Amejia481
Copy link
Contributor Author

Thanks for the update!

@brampitoyo
Copy link
Contributor

brampitoyo commented May 12, 2021

@Amejia481 Thanks for making these changes! Just a few issues remaining:


  • share

Sorry, this icon has just been redrawn and finalised today. Figma (you’ll notice that it’s positioned to the side of all other icons).


  • password (eye)
  • password hide (eye with cross)

These icons seem to not be coloured like all the other ones. They seem to have a little bit of transparency added. Was this intentional? If yes, then we’re all good to go. If no, then I think we should make the icon fill identical to all other icons.


  • website placeholder

Unfortunately, I wasn’t able to see this new icon anywhere in the app. Here are some places where the globe would’ve appeared, but the current icon is still used.


Tracking Protection

It seems like I couldn’t find these icons where they would normally appear: Settings → Enhanced Tracking Protection → ℹ️ Info.

Do we not show icons on this sub-pages (maybe we don’t)? And are there other places where the tracker-type icons are shown?


Add-ons Manager

For the rating half icon, I provided separate assets for light and dark themes, as well as a shape-only asset that you can manually colourise. Let me know if this isn’t the correct way to implement it, and I’ll be happy to generate a version that works!

@brampitoyo
Copy link
Contributor

I also found one icon from the previous batch that was not yet replaced: password (key symbol). Wonder whether I’ve forgotten to include it on the previous list? If so, then that’s my mistake – sorry about this!

The new password icon can be found in this Figma.

@Amejia481
Copy link
Contributor Author

Thanks for the review, I performed the following updates:

  • Share.
  • Website placeholder

Notes:

  • The password (eye) and password hide (eye with cross) icons, the previous versions already had the transparency on them, If you like I can remove them, I think the transparency was added before to match the Android equivalents.

  • The tracking Protection icons were removed on following this request [UX] ETP Cookie purging fenix#13812 (comment), not sure if I should I added then back? I think we are not showing them in other screens.

Amejia481 added a commit to Amejia481/android-components that referenced this issue May 12, 2021
Amejia481 added a commit to Amejia481/android-components that referenced this issue May 12, 2021
@brampitoyo
Copy link
Contributor

Thanks, @Amejia481!

  • If password and password-hide has transparency to match Android System style, we shouldn’t change that. Let’s keep it intact.
  • I missed the fact that the Tracking Protection tracker-type icons were removed late last year. It sounds like iOS is the platform that needs to catch up to Fenix. So, let’s not add the icon, and I will make sure that we are removing the icon on iOS. Thanks for posting the link to that issue!

@Amejia481 Amejia481 added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation May 13, 2021
@Amejia481 Amejia481 moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board May 13, 2021
@Amejia481 Amejia481 added E2 Estimation points: 2 and removed E3 Estimation points: 3 labels May 13, 2021
@Amejia481
Copy link
Contributor Author

I'm created a separated issue for updated the rating icon as It's taking too much time, it will be better to address it separately, and not block other icons on it.

Amejia481 added a commit to Amejia481/android-components that referenced this issue May 13, 2021
@mergify mergify bot closed this as completed in 5f318ee May 13, 2021
Android Engineering Team Kanban board automation moved this from In Development (WIP limit - 15) to Done May 13, 2021
mergify bot pushed a commit that referenced this issue May 17, 2021
(cherry picked from commit 5f318ee)

# Conflicts:
#	components/ui/icons/src/main/res/drawable/mozac_ic_broken_lock.xml
#	components/ui/icons/src/main/res/drawable/mozac_ic_sync.xml
Amejia481 added a commit that referenced this issue May 17, 2021
Amejia481 added a commit that referenced this issue May 17, 2021
Amejia481 added a commit that referenced this issue May 17, 2021
Amejia481 added a commit to Amejia481/android-components that referenced this issue May 18, 2021
Update tab counter icon

(cherry picked from commit 6028cf8)

update icons

(cherry picked from commit 3c7054d)

Minor icon updates

(cherry picked from commit e068d4d)

Second batch of new proton icons

(cherry picked from commit 867def8)

Closes mozilla-mobile#10231 update proton icons third batch

(cherry picked from commit 5f318ee)
@Amejia481 Amejia481 mentioned this issue May 18, 2021
4 tasks
Amejia481 added a commit to Amejia481/android-components that referenced this issue May 18, 2021
Update tab counter icon

(cherry picked from commit 6028cf8)

update icons

(cherry picked from commit 3c7054d)

Minor icon updates

(cherry picked from commit e068d4d)

Second batch of new proton icons

(cherry picked from commit 867def8)

Closes mozilla-mobile#10231 update proton icons third batch

(cherry picked from commit 5f318ee)

Update tab counter menu icons

(cherry picked from commit 0eb4122)
Amejia481 added a commit to Amejia481/android-components that referenced this issue May 18, 2021
Update tab counter icon

(cherry picked from commit 6028cf8)

update icons

(cherry picked from commit 3c7054d)

Minor icon updates

(cherry picked from commit e068d4d)

Second batch of new proton icons

(cherry picked from commit 867def8)

Closes mozilla-mobile#10231 update proton icons third batch

(cherry picked from commit 5f318ee)

Update tab counter menu icons

(cherry picked from commit 0eb4122)
Amejia481 added a commit that referenced this issue May 18, 2021
Update tab counter icon

(cherry picked from commit 6028cf8)

update icons

(cherry picked from commit 3c7054d)

Minor icon updates

(cherry picked from commit e068d4d)

Second batch of new proton icons

(cherry picked from commit 867def8)

Closes #10231 update proton icons third batch

(cherry picked from commit 5f318ee)

Update tab counter menu icons

(cherry picked from commit 0eb4122)
grigoryk pushed a commit to gabrielluong/android-components that referenced this issue Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2 Estimation points: 2
Projects
No open projects
Development

No branches or pull requests

2 participants