Add third batch of icons #10231
Comments
@Amejia481 Just a note before we get started: both the |
Thanks for the update! |
@Amejia481 Thanks for making these changes! Just a few issues remaining:
Sorry, this icon has just been redrawn and finalised today. Figma (you’ll notice that it’s positioned to the side of all other icons).
These icons seem to not be coloured like all the other ones. They seem to have a little bit of transparency added. Was this intentional? If yes, then we’re all good to go. If no, then I think we should make the icon fill identical to all other icons.
Unfortunately, I wasn’t able to see this new icon anywhere in the app. Here are some places where the globe would’ve appeared, but the current icon is still used. Tracking ProtectionIt seems like I couldn’t find these icons where they would normally appear: Settings → Enhanced Tracking Protection → ℹ️ Info. Do we not show icons on this sub-pages (maybe we don’t)? And are there other places where the tracker-type icons are shown? Add-ons Manager
For the rating half icon, I provided separate assets for light and dark themes, as well as a shape-only asset that you can manually colourise. Let me know if this isn’t the correct way to implement it, and I’ll be happy to generate a version that works! |
I also found one icon from the previous batch that was not yet replaced: password (key symbol). Wonder whether I’ve forgotten to include it on the previous list? If so, then that’s my mistake – sorry about this! The new password icon can be found in this Figma. |
Thanks for the review, I performed the following updates:
Notes:
|
Thanks, @Amejia481!
|
I'm created a separated issue for updated the rating icon as It's taking too much time, it will be better to address it separately, and not block other icons on it. |
(cherry picked from commit 5f318ee) # Conflicts: # components/ui/icons/src/main/res/drawable/mozac_ic_broken_lock.xml # components/ui/icons/src/main/res/drawable/mozac_ic_sync.xml
(cherry picked from commit 5f318ee)
(cherry picked from commit 5f318ee)
(cherry picked from commit 5f318ee)
Update tab counter icon (cherry picked from commit 6028cf8) update icons (cherry picked from commit 3c7054d) Minor icon updates (cherry picked from commit e068d4d) Second batch of new proton icons (cherry picked from commit 867def8) Closes mozilla-mobile#10231 update proton icons third batch (cherry picked from commit 5f318ee)
Update tab counter icon (cherry picked from commit 6028cf8) update icons (cherry picked from commit 3c7054d) Minor icon updates (cherry picked from commit e068d4d) Second batch of new proton icons (cherry picked from commit 867def8) Closes mozilla-mobile#10231 update proton icons third batch (cherry picked from commit 5f318ee) Update tab counter menu icons (cherry picked from commit 0eb4122)
Update tab counter icon (cherry picked from commit 6028cf8) update icons (cherry picked from commit 3c7054d) Minor icon updates (cherry picked from commit e068d4d) Second batch of new proton icons (cherry picked from commit 867def8) Closes mozilla-mobile#10231 update proton icons third batch (cherry picked from commit 5f318ee) Update tab counter menu icons (cherry picked from commit 0eb4122)
Update tab counter icon (cherry picked from commit 6028cf8) update icons (cherry picked from commit 3c7054d) Minor icon updates (cherry picked from commit e068d4d) Second batch of new proton icons (cherry picked from commit 867def8) Closes #10231 update proton icons third batch (cherry picked from commit 5f318ee) Update tab counter menu icons (cherry picked from commit 0eb4122)
See this comment mozilla-mobile/fenix#18132 (comment)
Permissions
Make sure that DRM-controlled content is using the new
link
icon – I think it already does?Tracking Protection
New Tab Page
info
icon e.g. in Add-ons Manager seems to be correct already)Add-ons Manager
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: