Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Uplift proton icons #10286

Merged
merged 2 commits into from
May 18, 2021

Conversation

Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented May 18, 2021

This is includes all commits related to updating proton icons + bumps the ac version.

Uplift proton icons

Update tab counter icon

(cherry picked from commit 6028cf8)

update icons

(cherry picked from commit 3c7054d)

Minor icon updates

(cherry picked from commit e068d4d)

Second batch of new proton icons

(cherry picked from commit 867def8)

Closes #10231 update proton icons third batch

(cherry picked from commit 5f318ee)

Update tab counter menu icons

(cherry picked from commit 0eb4122)

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Amejia481 Amejia481 added the do not land PRs that requires coordination before landing label May 18, 2021
@Amejia481 Amejia481 requested a review from a team as a code owner May 18, 2021 01:49
@mergify
Copy link
Contributor

mergify bot commented May 18, 2021

This pull request has conflicts when rebasing. Could you fix it @Amejia481? 🙏

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #10286 (1774f4c) into releases/75.0 (9713517) will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             releases/75.0   #10286      +/-   ##
===================================================
+ Coverage            76.46%   76.79%   +0.32%     
+ Complexity            2883     2563     -320     
===================================================
  Files                  381      317      -64     
  Lines                13491    11892    -1599     
  Branches              2122     1899     -223     
===================================================
- Hits                 10316     9132    -1184     
+ Misses                2132     1777     -355     
+ Partials              1043      983      -60     
Impacted Files Coverage Δ Complexity Δ
...mozilla/components/ui/tabcounter/TabCounterMenu.kt 85.71% <100.00%> (ø) 2.00 <0.00> (?)
...a/mozilla/components/support/base/ext/Throwable.kt 86.66% <0.00%> (-2.23%) 0.00% <0.00%> (ø%)
...ents/browser/state/reducer/CustomTabListReducer.kt
.../components/browser/state/ext/PermissionRequest.kt
.../components/concept/engine/window/WindowRequest.kt
...components/browser/state/reducer/TabListReducer.kt
...la/components/browser/state/reducer/UndoReducer.kt
...concept/engine/webextension/WebExtensionRuntime.kt
...illa/components/browser/state/state/EngineState.kt
...ponents/browser/state/reducer/LastAccessReducer.kt
... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9713517...1774f4c. Read the comment docs.

@mergify
Copy link
Contributor

mergify bot commented May 18, 2021

This pull request has conflicts when rebasing. Could you fix it @Amejia481? 🙏

@Amejia481 Amejia481 requested review from pocmo and removed request for a team May 18, 2021 11:10
@Amejia481 Amejia481 removed the do not land PRs that requires coordination before landing label May 18, 2021
@mergify
Copy link
Contributor

mergify bot commented May 18, 2021

This pull request has conflicts when rebasing. Could you fix it @Amejia481? 🙏

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label May 18, 2021
@Amejia481 Amejia481 added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels May 18, 2021
Update tab counter icon

(cherry picked from commit 6028cf8)

update icons

(cherry picked from commit 3c7054d)

Minor icon updates

(cherry picked from commit e068d4d)

Second batch of new proton icons

(cherry picked from commit 867def8)

Closes mozilla-mobile#10231 update proton icons third batch

(cherry picked from commit 5f318ee)

Update tab counter menu icons

(cherry picked from commit 0eb4122)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants