Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Change ImageView's tint instead of the Drawable's in WebExtensionBrowserMenuItem #10537

Closed
codrut-topliceanu opened this issue Jul 1, 2021 · 0 comments

Comments

@codrut-topliceanu
Copy link
Contributor

codrut-topliceanu commented Jul 1, 2021

Using .setTint(tint) on the WebExtensionBrowserMenuItem for "Report Site Issue" does not accurately display the proper color sent from Fenix.

To fix this we should replace it with imageView.setTintResource(tint).

┆Issue is synchronized with this Jira Task

@codrut-topliceanu codrut-topliceanu self-assigned this Jul 1, 2021
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Jul 1, 2021
 `Drawable.setTint` did not correctly apply the tint received from Fenix. Switching to `imageView.setTintResource` fixes the issue.
@codrut-topliceanu codrut-topliceanu added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Jul 1, 2021
@codrut-topliceanu codrut-topliceanu moved this from Ready for Engineering (min-5 ; max-22) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Jul 1, 2021
mergify bot pushed a commit that referenced this issue Jul 1, 2021
 `Drawable.setTint` did not correctly apply the tint received from Fenix. Switching to `imageView.setTintResource` fixes the issue.
Android Engineering Team Kanban board automation moved this from Dev Complete (WIP limit - 5) to Done Jul 1, 2021
grigoryk pushed a commit to gabrielluong/android-components that referenced this issue Sep 11, 2021
 `Drawable.setTint` did not correctly apply the tint received from Fenix. Switching to `imageView.setTintResource` fixes the issue.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

1 participant