Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Cannot use IconRequest as private. #10737

Closed
mcarare opened this issue Aug 3, 2021 · 1 comment
Closed

Cannot use IconRequest as private. #10737

mcarare opened this issue Aug 3, 2021 · 1 comment
Assignees
@mcarare
Labels
🎭 Focus Requirements for Focus/Klar

Comments

@mcarare
Copy link
Contributor

mcarare commented Aug 3, 2021 •
edited by data-sync-user

HttpIconLoader does not take into consideration isPrivate property so when you send a private IconRequest that property gets lost on the way. This prevents you to load icons in Focus because ClientWrapper prevents non-private requests.

┆Issue is synchronized with this Jira Task
@mcarare mcarare added the 🎭 Focus Requirements for Focus/Klar label Aug 3, 2021
@mcarare mcarare self-assigned this Aug 3, 2021
mcarare added a commit to mcarare/android-components that referenced this issue Aug 3, 2021
@mcarare
For mozilla-mobile#10737: Also pass isPrivate property to load method.
e42274d
mcarare added a commit to mcarare/android-components that referenced this issue Aug 3, 2021
@mcarare
For mozilla-mobile#10737: Also pass isPrivate property to download re…
b096485 
…quest.
mergify bot pushed a commit that referenced this issue Aug 3, 2021
@mcarare @mergify
For #10737: Also pass isPrivate property to download request.
a5b2922
@mcarare
Copy link
Contributor Author

mcarare commented Aug 4, 2021

Closed in #10738.

@mcarare mcarare closed this as completed Aug 4, 2021
grigoryk pushed a commit to gabrielluong/android-components that referenced this issue Sep 11, 2021
@mcarare
For mozilla-mobile#10737: Also pass isPrivate property to download re…
d3d4c9e 
…quest.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🎭 Focus Requirements for Focus/Klar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcarare