This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Update context menu builder and design #10822
Labels
E3
Estimation points: 3
Comments
4 tasks
|
Let's ping @brampitoyo here. It would be nice to have the same options as in Fenix - and I'm not sure if there's any reason to not have copy & share in Focus. |
|
@ionutbedregeanu I agree with @pocmo’s suggestion. Let’s keep the menu options as identical as possible between Focus and Fenix – for maximum consistency and maintainability. The only Focus-specific design element remaining is the caption text that says “Saved and shared images will not be deleted when you erase Firefox Focus history”. The rest can follow Fenix. Thanks! |
ionutbedregeanu
added this to Ready for Engineering (min-5 ; max-22)
in Android Engineering Team Kanban board
via automation
ionutbedregeanu
moved this from Ready for Engineering (min-5 ; max-22)
to In Development (WIP limit - 15)
in Android Engineering Team Kanban board
ionutbedregeanu
pushed a commit
to ionutbedregeanu/android-components
that referenced
this issue
Aug 18, 2021
Update context menu layout and add an additional note - For that a new flag was added
ionutbedregeanu
pushed a commit
to ionutbedregeanu/android-components
that referenced
this issue
Aug 18, 2021
Update context menu layout and add an additional note - For that a new flag was added
ionutbedregeanu
moved this from In Development (WIP limit - 15)
to Dev Complete (WIP limit - 5)
in Android Engineering Team Kanban board
ionutbedregeanu
pushed a commit
to ionutbedregeanu/android-components
that referenced
this issue
Aug 18, 2021
Update context menu layout and add an additional note - For that a new flag was added
ionutbedregeanu
pushed a commit
to ionutbedregeanu/android-components
that referenced
this issue
Aug 18, 2021
Update context menu layout and add an additional note - For that a new parameter was added
ionutbedregeanu
pushed a commit
to ionutbedregeanu/android-components
that referenced
this issue
Aug 19, 2021
Update context menu layout and add an additional note - For that a new parameter was added
mergify bot
pushed a commit
that referenced
this issue
Aug 24, 2021
Update context menu layout and add an additional note - For that a new parameter was added
ionutbedregeanu
moved this from Dev Complete (WIP limit - 5)
to Reviewer approved, ready for test (WIP limit - ?)
in Android Engineering Team Kanban board
|
Verified as fixed as per mozilla-mobile/focus-android#5098 (comment) |
Android Engineering Team Kanban board
automation
moved this from Reviewer approved, ready for test (WIP limit - ?)
to Done
Aug 31, 2021
grigoryk
pushed a commit
to gabrielluong/android-components
that referenced
this issue
Sep 11, 2021
Update context menu layout and add an additional note - For that a new parameter was added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Why/User Benefit/User Problem
We are constrained to make some updates on context menu classes because with the current implementation Share link and Copy link candidates are added to image/video context menu and according to the new design we don't want that
Also as we can see in Figma, context menu dialog UI was updated
What / Requirements
Acceptance Criteria (how do I know when I’m done?)
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: