Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Implement PromptInstanceDelegate #10867

Closed
agi opened this issue Aug 23, 2021 · 3 comments
Closed

Implement PromptInstanceDelegate #10867

agi opened this issue Aug 23, 2021 · 3 comments
Assignees
Labels
<autofill> Credit Card, Addresses and Logins autofill functionality <engine-gecko> Component: browser-engine-gecko 🌟 feature New functionality and improvements

Comments

@agi
Copy link
Contributor

agi commented Aug 23, 2021

Bug 1710668 is adding a new API to let GeckoView dismiss prompts that should not be displayed anymore (e.g. if the page navigated away and the prompt is not relevant or a login save prompt that contains known invalid credentials). AC should implement this delegate and dismiss the prompt when onPromptDismiss is called.

Without this you might start seeing stale onLoginSave prompts for HTTP Auth (e.g. when the user tries to login with invalid credentials)

┆Issue is synchronized with this Jira Task

@agi
Copy link
Contributor Author

agi commented Aug 23, 2021

To test this end to end:

  • Navigate to https://jigsaw.w3.org/HTTP/Basic/
  • Enter test test as username/password (these are intentionally incorrect credentials)
  • Page asks for credential again
  • Enter guest guest (correct credentials)
  • Page loads and user is asked to save password, only guest/guest is saved (without the change in this issue, you will get two prompts, one for guest/guest and one for test/test)

@jonalmeida jonalmeida added <autofill> Credit Card, Addresses and Logins autofill functionality <engine-gecko> Component: browser-engine-gecko 🌟 feature New functionality and improvements labels Aug 31, 2021
@codrut-topliceanu codrut-topliceanu self-assigned this Sep 6, 2021
@codrut-topliceanu
Copy link
Contributor

@agi onPromptDismiss is indeed called when the page is navigated away, so we have all we need to fix this issue, but I'd like to ask for some additional functionality:
Could onPromptDismiss be called when the user un-focuses a credit card form so that we may be able to fix this issue mozilla-mobile/fenix#19707 ?

@agi
Copy link
Contributor Author

agi commented Sep 7, 2021

Hi @codrut-topliceanu, yes we are planning to work on https://bugzilla.mozilla.org/show_bug.cgi?id=1715572 (which is the GV side of issue fenix#19707) in the next sprint.

@codrut-topliceanu codrut-topliceanu added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Sep 8, 2021
@codrut-topliceanu codrut-topliceanu moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Sep 8, 2021
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Sep 8, 2021
codrut-topliceanu pushed a commit to codrut-topliceanu/android-components that referenced this issue Sep 28, 2021
@codrut-topliceanu codrut-topliceanu moved this from In Development (WIP limit - 15) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Oct 6, 2021
@codrut-topliceanu codrut-topliceanu moved this from Reviewer approved, ready for test (WIP limit - ?) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Oct 6, 2021
Android Engineering Team Kanban board automation moved this from Dev Complete (WIP limit - 5) to Done Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<autofill> Credit Card, Addresses and Logins autofill functionality <engine-gecko> Component: browser-engine-gecko 🌟 feature New functionality and improvements
Projects
No open projects
Development

No branches or pull requests

3 participants