Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Have the additional_note from the context menu sticky #11829

Closed
Mugurell opened this issue Mar 9, 2022 · 2 comments
Closed

Have the additional_note from the context menu sticky #11829

Mugurell opened this issue Mar 9, 2022 · 2 comments
Assignees

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Mar 9, 2022

Issue seen on mozilla-mobile/focus-android#6593

┆Issue is synchronized with this Jira Task

@indurs
Copy link
Contributor

indurs commented Mar 9, 2022

Will work on this issue.

indurs pushed a commit to indurs/android-components that referenced this issue Mar 9, 2022
…enu sticky

A note should be displayed below all the options in the context menu when an image is clicked.
Issue - In landscape mode the note is not visible. The user has to scroll down to see the note

Files modified
1. components/feature/contextmenu/build.gradle

Added the following dependency
implementation Dependencies.androidx_constraintlayout

2. components/feature/contextmenu/src/main/res/layout/mozac_feature_contextmenu_dialog.xml
@indurs
Copy link
Contributor

indurs commented Mar 9, 2022

@Mugurell , I've submitted the PR for this issue.

indurs pushed a commit to indurs/android-components that referenced this issue Mar 10, 2022
…menu sticky

File modified

mozac_feature_contextmenu_dialog.xml

Added
android:clipToPadding="false" to recyclerview to avoid the content being clipped when scrolling

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
indurs pushed a commit to indurs/android-components that referenced this issue Mar 10, 2022
…xt menu sticky

For mozilla-mobile#11829: Have the additional_note from the context menu sticky

A note should be displayed below all the options in the context menu when an image is clicked.
Issue - In landscape mode the note is not visible. The user has to scroll down to see the note

Files modified
1. components/feature/contextmenu/build.gradle

Added the following dependency
implementation Dependencies.androidx_constraintlayout

2. components/feature/contextmenu/src/main/res/layout/mozac_feature_contextmenu_dialog.xml

For mozilla-mobile#11829 : Have the additional_note from the context menu sticky

File modified

mozac_feature_contextmenu_dialog.xml

Added
android:clipToPadding="false" to recyclerview to avoid the content being clipped when scrolling

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
Mugurell added a commit to Mugurell/android-components that referenced this issue Mar 10, 2022
…xt menu sticky

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
mergify bot pushed a commit that referenced this issue Mar 10, 2022
Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants