Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

3rd party logins autofill failing after unlock because of a parcelling error of ParsedStructure #11892

Closed
Mugurell opened this issue Mar 18, 2022 · 1 comment
Closed

3rd party logins autofill failing after unlock because of a parcelling error of ParsedStructure #11892

Mugurell opened this issue Mar 18, 2022 · 1 comment

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Mar 18, 2022 •
edited by data-sync-user

Seen in mozilla-mobile/fenix#24257 (comment)

2022-03-18 15:21:55.007 1722-1791/? E/Parcel: Class not found when unmarshalling: mozilla.components.feature.autofill.structure.ParsedStructure
    java.lang.ClassNotFoundException: mozilla.components.feature.autofill.structure.ParsedStructure
        at java.lang.Class.classForName(Native Method)
        at java.lang.Class.forName(Class.java:454)
        at android.os.Parcel.readParcelableCreator(Parcel.java:3338)
        at android.os.Parcel.readParcelable(Parcel.java:3272)
        at android.os.Parcel.readValue(Parcel.java:3174)
        at android.os.Parcel.readArrayMapInternal(Parcel.java:3567)
        at android.os.BaseBundle.initializeFromParcelLocked(BaseBundle.java:292)
        at android.os.BaseBundle.unparcel(BaseBundle.java:236)
        at android.os.Bundle.putAll(Bundle.java:292)
        at android.content.Intent.fillIn(Intent.java:10288)
        at com.android.server.am.PendingIntentRecord.sendInner(PendingIntentRecord.java:315)
        at com.android.server.wm.ActivityTaskManagerService.startActivityIntentSender(ActivityTaskManagerService.java:1222)
        at android.app.IActivityTaskManager$Stub.onTransact(IActivityTaskManager.java:1577)
        at android.os.Binder.execTransactInternal(Binder.java:1165)
        at android.os.Binder.execTransact(Binder.java:1134)

Fixing this also help with the issues from mozilla-mobile/fenix#23707

┆Issue is synchronized with this Jira Task
Mugurell added a commit to Mugurell/android-components that referenced this issue Mar 18, 2022
@Mugurell
For mozilla-mobile#11892 - Pass ParsedStructure as bytearray instead …
8af95e2 
…of as parcelable

This avoids the system trying to remap our ParsedStructure parcelable failing
by not using the right ClassLoader.
Mugurell added a commit to Mugurell/android-components that referenced this issue Mar 22, 2022
@Mugurell
For mozilla-mobile#11892 - Pass ParsedStructure as bytearray instead …
c9486d1 
…of as parcelable

This avoids the system trying to remap our ParsedStructure parcelable failing
by not using the right ClassLoader.

Implementing Parcelable on our own was needed to be able to manually create
`ParsedStructure` from the unmarshalled parcel.
Mugurell added a commit to Mugurell/android-components that referenced this issue Mar 23, 2022
@Mugurell
For mozilla-mobile#11892 - Pass ParsedStructure as bytearray instead …
864b50f 
…of as parcelable

This avoids the system trying to remap our ParsedStructure parcelable failing
by not using the right ClassLoader.

Implementing Parcelable on our own was needed to be able to manually create
`ParsedStructure` from the unmarshalled parcel.
Mugurell added a commit to Mugurell/android-components that referenced this issue May 4, 2022
@Mugurell
For mozilla-mobile#11892 - Pass ParsedStructure as bytearray instead …
d5806f2 
…of as parcelable

This avoids the system trying to remap our ParsedStructure parcelable failing
by not using the right ClassLoader.

Implementing Parcelable on our own was needed to be able to manually create
`ParsedStructure` from the unmarshalled parcel.
Mugurell added a commit to Mugurell/android-components that referenced this issue May 4, 2022
@Mugurell
For mozilla-mobile#11892 - Pass ParsedStructure as bytearray instead …
29b97b0 
…of as parcelable

This avoids the system trying to remap our ParsedStructure parcelable failing
by not using the right ClassLoader.

Implementing Parcelable on our own was needed to be able to manually create
`ParsedStructure` from the unmarshalled parcel.
mergify bot pushed a commit that referenced this issue May 4, 2022
@Mugurell @mergify
For #11892 - Pass ParsedStructure as bytearray instead of as parcelable
0559e5a 
This avoids the system trying to remap our ParsedStructure parcelable failing
by not using the right ClassLoader.

Implementing Parcelable on our own was needed to be able to manually create
`ParsedStructure` from the unmarshalled parcel.
@csadilek
Copy link
Contributor

Fixed by #11893.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csadilek @Mugurell