Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Change the SearchFeature flow to accept consecutive identical searches #12361

Closed
Alexandru2909 opened this issue Jun 21, 2022 · 0 comments · Fixed by nathanmkaya/android-components#362
Closed

Change the SearchFeature flow to accept consecutive identical searches #12361

Alexandru2909 opened this issue Jun 21, 2022 · 0 comments · Fixed by nathanmkaya/android-components#362
Assignees
@Alexandru2909

Comments

@Alexandru2909
Copy link
Contributor

Alexandru2909 commented Jun 21, 2022 •
edited

Fixes Fenix bug #25047

When SearchFeature checks for state changes, it should also accept null values, to allow the same query to be searched multiple times consequently.

┆Issue is synchronized with this Jira Task
@Alexandru2909 Alexandru2909 self-assigned this Jun 21, 2022
Alexandru2909 pushed a commit to Alexandru2909/android-components that referenced this issue Jun 21, 2022
For mozilla-mobile#12361 - Implement equals and hashCode methods for …
897a340 
…SearchRequest
Alexandru2909 pushed a commit to Alexandru2909/android-components that referenced this issue Jun 28, 2022
For mozilla-mobile#12361 - Implement equals and hashCode methods for …
9cdaf02 
…SearchRequest
@Alexandru2909 Alexandru2909 changed the title Implement equals and hashCode methods for SearchRequest Change the SearchFeature flow to accept consecutive identical searches Jun 28, 2022
Alexandru2909 pushed a commit to Alexandru2909/android-components that referenced this issue Jun 28, 2022
For mozilla-mobile#12361 - Changed distinctUntilChangedBy to `ifCha…
9fa79af 
…nged` in SearchFeature
mergify bot pushed a commit that referenced this issue Jun 28, 2022
@mergify
For #12361 - Changed distinctUntilChangedBy to ifChanged in Searc…
652527f 
…hFeature
@github-actions github-actions bot mentioned this issue Jul 22, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Alexandru2909 Alexandru2909

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pull] main from mozilla-mobile:main mozilla-mobile/android-components
1 participant
@Alexandru2909