Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Support force menu popup orientation #12398

Closed
rocketsroger opened this issue Jun 27, 2022 · 0 comments · Fixed by nathanmkaya/android-components#362
Closed

Support force menu popup orientation #12398

rocketsroger opened this issue Jun 27, 2022 · 0 comments · Fixed by nathanmkaya/android-components#362
Assignees
@rocketsroger

Comments

@rocketsroger
Copy link
Contributor

rocketsroger commented Jun 27, 2022 •
edited by data-sync-user

Currently, if the popup window does not fit in the available height, we show the window by disregarding the orientation. Add support to respect the orientation if the caller wants to force it.

┆Issue is synchronized with this Jira Task
@rocketsroger rocketsroger self-assigned this Jun 27, 2022
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Jun 27, 2022
@rocketsroger
Close mozilla-mobile#12398: Add support for forcing menu orientation
0904388
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Jun 28, 2022
@rocketsroger
Close mozilla-mobile#12398: Add support for forcing menu orientation
b6ccde9
@mergify mergify bot closed this as completed in f7ada85 Jun 28, 2022
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Jun 28, 2022
@rocketsroger
Close mozilla-mobile#12398: Do not scroll menu to bottom with up orie…
a78b34e 
…ntation
mergify bot pushed a commit that referenced this issue Jun 29, 2022
@rocketsroger @mergify
Close #12398: Do not scroll menu to bottom with up orientation
19fa535
@github-actions github-actions bot mentioned this issue Jul 22, 2022
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Oct 31, 2022
@rocketsroger @mergify
[components] Close mozilla-mobile/android-components#12398: Add suppo…
af86e76 
…rt for forcing menu orientation
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Oct 31, 2022
@rocketsroger @mergify
[components] Close mozilla-mobile/android-components#12398: Do not sc…
802c246 
…roll menu to bottom with up orientation
@mavduevskiy mavduevskiy mentioned this issue Dec 5, 2022
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pull] main from mozilla-mobile:main mozilla-mobile/android-components
1 participant
@rocketsroger