Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Firefox Suggest header for library suggestion section of URL bar #12443

Closed
sarah541 opened this issue Jul 6, 2022 · 1 comment · Fixed by #12444, #12530 or nathanmkaya/android-components#362
Assignees
Milestone

Comments

@sarah541
Copy link
Contributor

sarah541 commented Jul 6, 2022

User Story

Adding the 'Firefox Suggest' branded term to URL bar suggestions pulled from library data is intended to:

Emphasize to users that library data suggestions are being generated by Firefox, and are distinct from default search suggestions

Lay the groundwork for Firefox Suggest, which is intended to further increase the value users derive from Firefox suggested results for partial query strings

Link to spec, and design mockup for reference.

Please disregard the “Sponsored” components of the design mockup, including sponsored suggestions and related settings options. Those items will be addressed in a separate issue.

Acceptance Criteria

The branded term of “Firefox Suggest” is included as a header for the section of Fenix URL bar suggestions pulled from user library data (i.e. suggested bookmarks, history, open tabs).

┆Issue is synchronized with this Jira Task

@sarah541 sarah541 self-assigned this Jul 6, 2022
sarah541 added a commit to sarah541/android-components that referenced this issue Jul 6, 2022
sarah541 added a commit to sarah541/android-components that referenced this issue Jul 6, 2022
sarah541 added a commit to sarah541/android-components that referenced this issue Jul 7, 2022
sarah541 added a commit to sarah541/android-components that referenced this issue Jul 13, 2022
sarah541 added a commit to sarah541/android-components that referenced this issue Jul 13, 2022
sarah541 added a commit to sarah541/android-components that referenced this issue Jul 13, 2022
sarah541 added a commit to sarah541/android-components that referenced this issue Jul 13, 2022
@mergify mergify bot closed this as completed in #12444 Jul 14, 2022
@github-actions github-actions bot added this to the 104.0.0 🥵 milestone Jul 14, 2022
sarah541 added a commit to sarah541/android-components that referenced this issue Jul 20, 2022
@delia-pop
Copy link

delia-pop commented Jul 25, 2022

Verified as fixed on Nightly 104 from 07/24 with Google Pixel 6 (Android 12). The "Firefox Suggest" header is displayed under the non-library suggestions, when data suggestions from history, bookmarks and open tabs is available.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.