Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Build error (on Mac?) when building feature-toolbar #1485

Closed
pocmo opened this issue Nov 27, 2018 · 6 comments
Closed

Build error (on Mac?) when building feature-toolbar #1485

pocmo opened this issue Nov 27, 2018 · 6 comments
Assignees
Labels
🐞 bug Something isn't working
Milestone

Comments

@pocmo
Copy link
Contributor

pocmo commented Nov 27, 2018

e: /Users/skaspari/Projects/Mozilla/ac-backup/components/feature/toolbar/src/main/java/mozilla/components/feature/toolbar/ToolbarAutocompleteFeature.kt: (7, 43): Unresolved reference: DomainAutocompleteProvider
e: /Users/skaspari/Projects/Mozilla/ac-backup/components/feature/toolbar/src/main/java/mozilla/components/feature/toolbar/ToolbarAutocompleteFeature.kt: (19, 46): Unresolved reference: DomainAutocompleteProvider
e: /Users/skaspari/Projects/Mozilla/ac-backup/components/feature/toolbar/src/main/java/mozilla/components/feature/toolbar/ToolbarAutocompleteFeature.kt: (39, 37): Unresolved reference: DomainAutocompleteProvider
e: /Users/skaspari/Projects/Mozilla/ac-backup/components/feature/toolbar/src/main/java/mozilla/components/feature/toolbar/ToolbarAutocompleteFeature.kt: (52, 28): Unresolved reference: DomainAutocompleteProvider
e: /Users/skaspari/Projects/Mozilla/ac-backup/components/feature/toolbar/src/main/java/mozilla/components/feature/toolbar/ToolbarAutocompleteFeature.kt: (53, 25): Unresolved reference: getAutocompleteSuggestion
> Task :feature-toolbar:compileDebugKotlin FAILED

┆Issue is synchronized with this Jira Task

@pocmo pocmo added the 🐞 bug Something isn't working label Nov 27, 2018
@pocmo
Copy link
Contributor Author

pocmo commented Nov 27, 2018

This seems to be caused by us having two DomainAutocompleteProvider now (in different cases):

mozilla.components.browser.domains.DomainAutocompleteProvider (in Providers.kt)
mozilla.components.browser.domains.DomainAutoCompleteProvider (in DomainAutoCompleteProvider.kt)

@pocmo
Copy link
Contributor Author

pocmo commented Nov 27, 2018

Since taskcluster is using Linux it doesn't seem to be affected by this :)

@pocmo
Copy link
Contributor Author

pocmo commented Nov 27, 2018

CC @grigoryk

@pocmo pocmo self-assigned this Nov 27, 2018
@pocmo
Copy link
Contributor Author

pocmo commented Nov 27, 2018

I'll try whether that affects the reference browser. If it does then we may need to ship a dot release.

@pocmo
Copy link
Contributor Author

pocmo commented Nov 27, 2018

Using the updated components in the reference browser or in Focus do not seem to cause any issues like that.

@grigoryk
Copy link
Contributor

Ah, my bad. Benefits of running Linux...

@pocmo pocmo added this to the 0.34 😸 milestone Nov 28, 2018
pocmo added a commit to pocmo/android-components that referenced this issue Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants