Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Custom Tabs: Pressing the back button doesn't close the session #2874

Closed
jonalmeida opened this issue Apr 29, 2019 · 2 comments
Closed

Custom Tabs: Pressing the back button doesn't close the session #2874

jonalmeida opened this issue Apr 29, 2019 · 2 comments
Labels
🐞 bug Something isn't working <customtabs> Component: feature-customtabs 🐉 Fenix Feature needed for Fenix P2 🌐 reference browser Features, bugs, issues related to the reference browser implementation
Milestone

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Apr 29, 2019

See the following issues for STR:

We should be closing the session in the SessionManager before we invoke the close callback here: https://github.com/mozilla-mobile/android-components/blob/master/components/feature/customtabs/src/main/java/mozilla/components/feature/customtabs/CustomTabsToolbarFeature.kt#L109

┆Issue is synchronized with this Jira Task

@jonalmeida jonalmeida added <customtabs> Component: feature-customtabs 🌐 reference browser Features, bugs, issues related to the reference browser implementation 🐉 Fenix Feature needed for Fenix 🐞 bug Something isn't working labels Apr 29, 2019
@pocmo
Copy link
Contributor

pocmo commented Apr 29, 2019

@jonalmeida
Copy link
Contributor Author

Mh, some time ago I added this to RB:
https://github.com/mozilla-mobile/reference-browser/blob/master/app/src/main/java/org/mozilla/reference/browser/BrowserActivity.kt#L72

Ah ha! This would go away when we fix this in the CT toolbar.

@vesta0 vesta0 added the P1 label May 6, 2019
@mheubusch mheubusch added P2 and removed P1 labels May 7, 2019
jonalmeida added a commit to jonalmeida/android-components that referenced this issue May 8, 2019
jonalmeida added a commit to jonalmeida/android-components that referenced this issue May 8, 2019
@pocmo pocmo added this to the 0.52.0 🥖 milestone May 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Something isn't working <customtabs> Component: feature-customtabs 🐉 Fenix Feature needed for Fenix P2 🌐 reference browser Features, bugs, issues related to the reference browser implementation
Projects
None yet
Development

No branches or pull requests

4 participants