Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Refactor AbstractFetchDownloadService to not use LocalBroadcastManager #4378

Closed
pocmo opened this issue Sep 11, 2019 · 0 comments
Closed

Refactor AbstractFetchDownloadService to not use LocalBroadcastManager #4378

pocmo opened this issue Sep 11, 2019 · 0 comments
Labels
⌨️ code Technical debt, code clean up, small API change .. <download> Component: feature-download Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Extra attention is needed

Comments

@pocmo
Copy link
Contributor

pocmo commented Sep 11, 2019 •
edited by data-sync-user
Loading

We are using LocalBroadcastManager in AbstractFetchDownloadService. LocalBroadcastManager has been deprecated:

LocalBroadcastManager is an application-wide event bus and embraces layer violations in your app: any component may listen events from any other. You can replace usage of LocalBroadcastManager with other implementation of observable pattern, depending on your usecase suitable options may be LiveData or reactive streams.

In our case we already have the DownloadsFeature and could potentially extend that to support notifying the app of completed downloads.

┆Issue is synchronized with this Jira Task
@pocmo pocmo added help wanted Extra attention is needed ⌨️ code Technical debt, code clean up, small API change .. Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! <download> Component: feature-download labels Sep 11, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Sep 11, 2019
@pocmo
Update AndroidX dependencies.
bf62147 
Follow-up issues:
* mozilla-mobile#4379
* mozilla-mobile#4378
@pocmo pocmo mentioned this issue Sep 11, 2019
Merged
6 tasks
pocmo added a commit to pocmo/android-components that referenced this issue Sep 11, 2019
@pocmo
Update AndroidX dependencies.
92358d8 
Follow-up issues:
* mozilla-mobile#4379
* mozilla-mobile#4378
pocmo added a commit to pocmo/android-components that referenced this issue Sep 11, 2019
@pocmo
Update AndroidX dependencies.
088c179 
Follow-up issues:
* mozilla-mobile#4379
* mozilla-mobile#4378
bors bot pushed a commit that referenced this issue Sep 11, 2019
@MozLando @pocmo
Merge #4380
9ae9482 
4380: Update AndroidX dependencies. r=Amejia481 a=pocmo

Follow-up issues:
* #4379
* #4378



Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
@data-sync-user data-sync-user changed the title Refactor AbstractFetchDownloadService to not use LocalBroadcastManager FNX3-22443 ⁃ Refactor AbstractFetchDownloadService to not use LocalBroadcastManager Aug 2, 2020
@data-sync-user data-sync-user changed the title FNX3-22443 ⁃ Refactor AbstractFetchDownloadService to not use LocalBroadcastManager FNX2-16912 ⁃ Refactor AbstractFetchDownloadService to not use LocalBroadcastManager Aug 2, 2020
@st3fan st3fan changed the title FNX2-16912 ⁃ Refactor AbstractFetchDownloadService to not use LocalBroadcastManager Refactor AbstractFetchDownloadService to not use LocalBroadcastManager Aug 5, 2020
@pocmo pocmo closed this as completed Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
⌨️ code Technical debt, code clean up, small API change .. <download> Component: feature-download Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pocmo