Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Provide thumbnail of websites (browser-engine-system) #495

Closed
pocmo opened this issue Jul 25, 2018 · 7 comments
Closed

Provide thumbnail of websites (browser-engine-system) #495

pocmo opened this issue Jul 25, 2018 · 7 comments
Assignees
Labels
<engine-system> Component: browser-engine-system (WebView) 🌟 feature New functionality and improvements 🚀 Rocket Requirements for Firefox Rocket <session> Component: browser-session
Milestone

Comments

@pocmo
Copy link
Contributor

pocmo commented Jul 25, 2018

This is something that especially tabs trays make use of. Can be helpful for fancy animations or previews outside of the app too (e.g. notifications?).

Fennec has a thumbnail for every Tab (in our case Session). It even saves them to disk to use in (the old version of) top sites.

┆Issue is synchronized with this Jira Task

@pocmo pocmo added 🌟 feature New functionality and improvements <session> Component: browser-session <engine-gecko> Component: browser-engine-gecko <engine-system> Component: browser-engine-system (WebView) 🚀 Rocket Requirements for Firefox Rocket labels Jul 25, 2018
@pocmo
Copy link
Contributor Author

pocmo commented Aug 28, 2018

Fire TV has a method for that too: https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/amazonWebview/java/org/mozilla/focus/webview/FirefoxAmazonWebView.kt#L167-L174

This is used for taking screenshots of pages when adding them as tile to the home screen.

@pocmo
Copy link
Contributor Author

pocmo commented Aug 28, 2018

@pocmo
Copy link
Contributor Author

pocmo commented Aug 28, 2018

@pocmo pocmo added this to the 0.22 🍄 milestone Aug 31, 2018
@pocmo pocmo self-assigned this Aug 31, 2018
@pocmo
Copy link
Contributor Author

pocmo commented Sep 6, 2018

Talked to snorp and if GeckoView would add such an API then it would probably exist on GeckoSession. So we may want to add this API to EngineSession and only implement it for WebView for now.

@pocmo pocmo changed the title Provide thumbnail of websites Provide thumbnail of websites (browser-engine-system) Sep 6, 2018
@pocmo
Copy link
Contributor Author

pocmo commented Sep 6, 2018

In Firefox for Fire TV I wrote an extension method to add this functionality until we implement it here (On EngineView instead of EngineSession though):
https://github.com/mozilla-mobile/firefox-tv/blob/7742000ee1b1b870a6ed20cc6bcdf4001cbf8071/app/src/main/java/org/mozilla/focus/ext/EngineView.kt#L106-L119

@pocmo
Copy link
Contributor Author

pocmo commented Sep 6, 2018

We may want to add this to Sessionas Consumable<Bitmap>.

With that we may want to add a onLowMemory() or onTrimMemory() method to sessionManager and then sessionManager would remove the bitmap from all Sessions (Maybe keep it for the selected one?).

@pocmo
Copy link
Contributor Author

pocmo commented Sep 6, 2018

I'll un-assign myself: I'm still pretty busy with browser-engine integration into Firefox for Fire TV and browser-session integration into Focus.

@pocmo pocmo removed their assignment Sep 6, 2018
@pocmo pocmo removed the <engine-gecko> Component: browser-engine-gecko label Sep 7, 2018
@pocmo pocmo modified the milestones: 0.22 🍄, 0.23 🗿 Sep 7, 2018
@csadilek csadilek modified the milestones: 0.23 🗿, 0.24 🚀 Sep 12, 2018
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 15, 2018
* Adding captureThumbnail to EngineSession

* Updading TabViewHolder to add thumbnail

* Adding thumbnail to Session

* Adding gradle build constant to sample-browser to switch between engines
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 18, 2018
* Adding captureThumbnail to EngineSession

* Updating TabViewHolder to add thumbnail

* Adding thumbnail to Session

* Adding a new product flavor for systemEngine
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 18, 2018
* Adding captureThumbnail to EngineSession

* Updating TabViewHolder to add thumbnail

* Adding thumbnail to Session

* Adding a new product flavor for systemEngine
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 19, 2018
* Adding captureThumbnail to EngineSession

* Updating TabViewHolder to add thumbnail

* Adding thumbnail to Session

* Adding a new product flavor for systemEngine
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 19, 2018
* Adding captureThumbnail to EngineSession

* Updating TabViewHolder to add thumbnail

* Adding thumbnail to Session

* Adding a new product flavor for systemEngine
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 19, 2018
* Adding captureThumbnail to EngineSession

* Updating TabViewHolder to add thumbnail

* Adding thumbnail to Session

* Adding a new product flavor for systemEngine
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 19, 2018
* Adding captureThumbnail to EngineSession

* Updating TabViewHolder to add thumbnail

* Adding thumbnail to Session

* Adding a new product flavor for systemEngine
csadilek pushed a commit that referenced this issue Sep 20, 2018
* Adding captureThumbnail to EngineSession

* Updating TabViewHolder to add thumbnail

* Adding thumbnail to Session

* Adding a new product flavor for systemEngine
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<engine-system> Component: browser-engine-system (WebView) 🌟 feature New functionality and improvements 🚀 Rocket Requirements for Firefox Rocket <session> Component: browser-session
Projects
None yet
Development

No branches or pull requests

3 participants