Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

For #10037: Adjust BrowserMenuImageTextCheckboxButton item to fit UX specs. #10039

Merged
merged 2 commits into from Apr 12, 2021
Merged

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Apr 7, 2021

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

Screenshot_20210408-081743

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@mcarare mcarare requested a review from a team as a code owner April 7, 2021 13:43
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #10039 (e96241b) into master (6166683) will increase coverage by 1.82%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10039      +/-   ##
============================================
+ Coverage     73.57%   75.39%   +1.82%     
+ Complexity     5892     1374    -4518     
============================================
  Files           803      225     -578     
  Lines         29647     6264   -23383     
  Branches       4892      939    -3953     
============================================
- Hits          21813     4723   -17090     
+ Misses         5303     1136    -4167     
+ Partials       2531      405    -2126     
Impacted Files Coverage Δ Complexity Δ
...er/menu/item/BrowserMenuImageTextCheckboxButton.kt 86.48% <85.71%> (-0.62%) 10.00 <0.00> (ø)
.../components/feature/top/sites/PinnedSiteStorage.kt
...ure/addons/update/GlobalAddonDependencyProvider.kt
...omponents/feature/top/sites/db/PinnedSiteEntity.kt
...eature/prompts/widget/LoginPanelTextInputLayout.kt
...la/components/feature/pwa/WebAppShortcutManager.kt
...va/mozilla/components/lib/crash/db/ReportEntity.kt
...la/components/feature/toolbar/ToolbarInteractor.kt
...ture/addons/ui/UnsupportedAddonsAdapterDelegate.kt
...nts/feature/accounts/FirefoxAccountsAuthFeature.kt
... and 569 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6166683...e96241b. Read the comment docs.

@mcarare mcarare added the 🕵️‍♀️ needs review PRs that need to be reviewed label Apr 7, 2021
Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let's get screenshots and approval from @violasong before we merge this 🎉

Copy link
Collaborator

@violasong violasong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change! Looks good.

@mcarare mcarare added 🛬 needs landing PRs that are ready to land and removed do not land PRs that requires coordination before landing 🧙‍♂️ Needs UX Feedback labels Apr 12, 2021
@mergify mergify bot merged commit 669e099 into mozilla-mobile:master Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants