Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Issue #10335: Update appcompat and fragment dependencies to 1.3.x. #10359

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

pocmo
Copy link
Contributor

@pocmo pocmo commented May 27, 2021

@pocmo pocmo added the 🕵️‍♀️ needs review PRs that need to be reviewed label May 27, 2021
@pocmo pocmo requested review from Amejia481, csadilek and a team as code owners May 27, 2021 15:18
Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@bfd65ba). Click here to learn what that means.
The diff coverage is 84.40%.

❗ Current head 7a279d0 differs from pull request most recent head f16fe84. Consider uploading reports for the commit f16fe84 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10359   +/-   ##
=========================================
  Coverage          ?   74.32%           
  Complexity        ?     6294           
=========================================
  Files             ?      834           
  Lines             ?    31876           
  Branches          ?     5270           
=========================================
  Hits              ?    23691           
  Misses            ?     5491           
  Partials          ?     2694           
Impacted Files Coverage Δ
...ents/browser/domains/DomainAutoCompleteProvider.kt 60.52% <ø> (ø)
...java/mozilla/components/browser/domains/Domains.kt 67.74% <0.00%> (ø)
...lla/components/browser/engine/gecko/GeckoEngine.kt 88.25% <ø> (ø)
...ponents/browser/engine/gecko/GeckoEngineSession.kt 86.00% <ø> (ø)
...ts/browser/engine/gecko/GeckoEngineSessionState.kt 48.27% <ø> (ø)
...components/browser/engine/gecko/GeckoEngineView.kt 54.65% <ø> (ø)
...lla/components/browser/engine/gecko/GeckoResult.kt 88.46% <ø> (ø)
...components/browser/engine/gecko/NestedGeckoView.kt 87.75% <ø> (ø)
...ne/gecko/TrackingProtectionExceptionFileStorage.kt 90.90% <ø> (ø)
...ser/engine/gecko/activity/GeckoActivityDelegate.kt 100.00% <ø> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd65ba...f16fe84. Read the comment docs.

@rocketsroger rocketsroger added do not land PRs that requires coordination before landing and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Jun 10, 2021
@rocketsroger
Copy link
Contributor

Testing with Fenix side change before merging

@rocketsroger rocketsroger removed the do not land PRs that requires coordination before landing label Jun 14, 2021
@rocketsroger rocketsroger added the 🛬 needs landing PRs that are ready to land label Jun 14, 2021
@pocmo pocmo deleted the appcompat branch June 14, 2021 16:49
@pocmo pocmo restored the appcompat branch June 14, 2021 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants