Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

for #11990 - The Play/Pause button remains displayed on the media notification #11991

Merged
merged 2 commits into from Apr 20, 2022
Merged

for #11990 - The Play/Pause button remains displayed on the media notification #11991

merged 2 commits into from Apr 20, 2022

Conversation

iorgamgabriel
Copy link
Contributor

@iorgamgabriel iorgamgabriel commented Apr 12, 2022 •
edited

screen-20220411-165635_s6LlqP3J.mp4

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@iorgamgabriel iorgamgabriel mentioned this pull request Apr 12, 2022
Closed
@iorgamgabriel iorgamgabriel requested a review from a team as a code owner April 12, 2022 12:27
@Dexterp37
Copy link
Contributor

@iorgamgabriel can we kindly retain the telemetry test and instead retrigger the failure? We'll be looking into the intermittent, but it's better for this to stay active.

@iorgamgabriel iorgamgabriel added 🕵️‍♀️ needs review PRs that need to be reviewed labels Apr 14, 2022
rocketsroger
rocketsroger approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks

@rocketsroger rocketsroger added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Apr 20, 2022
@mergify mergify bot merged commit a8e3e61 into main Apr 20, 2022
@bors bors bot deleted the 11990 branch April 20, 2022 22:22
@rocketsroger rocketsroger mentioned this pull request Jun 7, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rocketsroger rocketsroger rocketsroger approved these changes

Assignees
No one assigned
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iorgamgabriel @Dexterp37 @rocketsroger @MickeyMoz