Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

For #1481. Use androidx runner in feature-prompts. #3395

Merged
merged 3 commits into from
Jun 12, 2019

Conversation

dector
Copy link
Contributor

@dector dector commented Jun 11, 2019

Issue #1481

  • Enable includeAndroidResources and enableUnitTestBinaryResources for feature-prompts module.
  • Use AndroidJUnit4 as a test runner (from AndroidX Test Ext).

Complexity

Easy (★☆☆)

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@dector dector requested a review from a team as a code owner June 11, 2019 18:06
@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #3395 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3395      +/-   ##
============================================
- Coverage     81.44%   81.33%   -0.12%     
- Complexity     2968     3324     +356     
============================================
  Files           400      411      +11     
  Lines         13585    14526     +941     
  Branches       1944     2064     +120     
============================================
+ Hits          11064    11814     +750     
- Misses         1750     1868     +118     
- Partials        771      844      +73
Impacted Files Coverage Δ Complexity Δ
...nents/browser/storage/sync/PlacesHistoryStorage.kt 97.82% <0%> (-0.22%) 18% <0%> (-2%)
...ava/mozilla/components/feature/pwa/ext/Activity.kt
.../java/mozilla/components/support/ktx/kotlin/Map.kt
...mozilla/components/support/ktx/kotlin/ByteArray.kt
...ozilla/components/support/ktx/android/view/View.kt
...components/support/ktx/android/view/MotionEvent.kt
...ava/mozilla/components/support/ktx/java/io/File.kt
...java/mozilla/components/support/ktx/kotlin/Char.kt
...ponents/feature/pwa/AbstractWebAppShellActivity.kt
...ts/support/ktx/android/content/res/AssetManager.kt
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae27040...2f837e6. Read the comment docs.

@pocmo pocmo merged commit 8028cd3 into mozilla-mobile:master Jun 12, 2019
@dector dector deleted the fix-1481-feature-prompts branch June 12, 2019 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants