Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #5929: Emit facts during migration #5932

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

jonalmeida
Copy link
Contributor


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #5932 into master will decrease coverage by 28.56%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #5932       +/-   ##
=============================================
- Coverage     78.90%   50.33%   -28.57%     
+ Complexity     4988       17     -4971     
=============================================
  Files           591       20      -571     
  Lines         24337      296    -24041     
  Branches       3654       27     -3627     
=============================================
- Hits          19203      149    -19054     
+ Misses         3732      139     -3593     
+ Partials       1402        8     -1394     
Impacted Files Coverage Δ Complexity Δ
...lla/components/browser/menu2/candidate/MenuIcon.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
...a/mozilla/components/concept/push/PushProcessor.kt 95.83% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
...fetch/httpurlconnection/HttpURLConnectionClient.kt 85.52% <0.00%> (+0.37%) 2.00% <0.00%> (-2.00%) ⬆️
...va/mozilla/components/support/locale/Extensions.kt 75.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
...mozilla/components/support/locale/LocaleManager.kt 97.61% <0.00%> (ø) 11.00% <0.00%> (ø%) ⬆️
...omponents/support/locale/LocaleAwareApplication.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
...nts/support/locale/LocaleAwareAppCompatActivity.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%) ⬆️
...la/components/feature/pwa/WebAppShortcutManager.kt
.../java/mozilla/components/concept/fetch/Response.kt
...mozilla/components/support/ktx/kotlin/ByteArray.kt
... and 573 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feddd36...30c5b41. Read the comment docs.

@jonalmeida
Copy link
Contributor Author

bors r=pocmo

bors bot pushed a commit that referenced this pull request Feb 14, 2020
5932: Closes #5929: Emit facts during migration r=pocmo a=jonalmeida



Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
@bors
Copy link

bors bot commented Feb 14, 2020

Build succeeded

  • complete-push

@bors bors bot merged commit 30c5b41 into mozilla-mobile:master Feb 14, 2020
@jonalmeida jonalmeida deleted the issue-5929 branch February 14, 2020 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants