Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #8172: Add a new "Fenix" Leanplum attribute #8208

Merged
merged 3 commits into from
Feb 13, 2020

Conversation

ValentinTimisica
Copy link
Contributor

Pull Request checklist

  • Tests: This PR does not include thorough tests.
  • Screenshots: This PR does not include screenshots or GIFs.
  • Accessibility: The code in this PR does not include any user facing features.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ValentinTimisica ValentinTimisica changed the title For #8172: Add a new "Fenix" Leanplum attribute For #8172: Add a new "Fenix" Leanplum attribute Feb 7, 2020
@codecov-io
Copy link

codecov-io commented Feb 7, 2020

Codecov Report

Merging #8208 into master will increase coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8208      +/-   ##
============================================
+ Coverage      18.6%   18.76%   +0.16%     
- Complexity      452      454       +2     
============================================
  Files           316      315       -1     
  Lines         12435    12308     -127     
  Branches       1634     1617      -17     
============================================
- Hits           2313     2310       -3     
+ Misses         9923     9798     -125     
- Partials        199      200       +1
Impacted Files Coverage Δ Complexity Δ
...fenix/components/metrics/LeanplumMetricsService.kt 25.64% <0%> (-0.61%) 2 <0> (ø)
...a/fenix/components/metrics/AdjustMetricsService.kt 3.44% <0%> (-3.22%) 1% <0%> (ø)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 71.86% <0%> (-1.94%) 28% <0%> (ø)
...ain/java/org/mozilla/fenix/components/Analytics.kt 25% <0%> (-1.83%) 1% <0%> (ø)
...in/java/org/mozilla/fenix/components/Components.kt 34.09% <0%> (-1.47%) 1% <0%> (ø)
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 10.95% <0%> (-0.46%) 10% <0%> (ø)
...la/fenix/components/metrics/GleanMetricsService.kt 7.59% <0%> (-0.29%) 3% <0%> (ø)
...org/mozilla/fenix/crashes/CrashReporterFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...la/fenix/settings/quicksettings/WebsiteInfoView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb5fb5...6968bb2. Read the comment docs.

@boek
Copy link
Contributor

boek commented Feb 7, 2020

Can you please fill out a data review request? :) https://github.com/mozilla/data-review/blob/master/request.md

@boek boek added the needs:data-review PR is awaiting a data review label Feb 7, 2020
@ValentinTimisica ValentinTimisica changed the title For #8172: Add a new "Fenix" Leanplum attribute For #8172: Add a new "Fenix" Leanplum attribute Feb 7, 2020
@ValentinTimisica
Copy link
Contributor Author

ValentinTimisica commented Feb 10, 2020

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • If the current app is Fenix.
  • If the migration from Fennec to Fenix completed successfully.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • Leanplum marketing campaigns.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A
  1. Can current instrumentation answer these questions?
  • No.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • Category 1.
  1. How long will this data be collected?
  • N/A
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Leanplum
  1. Where do you intend to share the results of your analysis?
  • Only on Leanplum with the people who have the right permissions.

@ValentinTimisica ValentinTimisica added the pr:needs-changes PRs that need some changes/fixes before they can land label Feb 11, 2020
@ValentinTimisica ValentinTimisica removed the pr:needs-changes PRs that need some changes/fixes before they can land label Feb 11, 2020
@ValentinTimisica
Copy link
Contributor Author

As @lwa-moz suggested in this comment I also added a E_Fennec_To_Fenix_Migrated Leanplum event which will be sent when the user has successfully migrated from Fennec to Fenix.

@st3fan
Copy link
Contributor

st3fan commented Feb 13, 2020

Added @jonalmeida and @pocmo as reviewers

if (state.progress == MigrationProgress.COMPLETED) {
metrics.track(Event.FennecToFenixMigrated)
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work. As an alternative we could also emit a Fact from the component. With that you wouldn't need to listen here indefinitely.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pocmo if that is easy let's do it. I'm going to land this for now. I filed mozilla-mobile/android-components#5929, if that lands I'll factor out this code and use the Fact instead 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put up a PR for this: mozilla-mobile/android-components#5932

@st3fan
Copy link
Contributor

st3fan commented Feb 13, 2020

@ValentinTimisica @boek if we want this to land in the last Migration Nightly build (which we will do tomorrow) then this needs a data review and land today.

@boek boek force-pushed the f-8172 branch 2 times, most recently from 468e79e to 0004cc8 Compare February 13, 2020 21:20
…lum event

This new event will be sent when the user has successfully migrated from Fennec
to Fenix.
This event will only be sent to Leanplum and not to the other telemetry
services like Glean or Adjust.

Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro>
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, mma.md

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, under data controls

  3. If the request is for permanent data collection, is there someone who will monitor the data over time? Yes, the fenix-core team

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    Type 1 & Type 2

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    Yes

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Will check-in at next data review meeting

  9. Does the data collection use a third-party collection tool?
    Yes, Leanplum

@boek boek merged commit 127169f into mozilla-mobile:master Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants