Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Adds Android 8.1 to the check inside setLayoutDirectionlfNeeded #6834

Merged
merged 1 commit into from May 1, 2020

Conversation

boek
Copy link
Contributor

@boek boek commented Apr 30, 2020

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #6834 into master will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6834      +/-   ##
============================================
+ Coverage     77.58%   77.83%   +0.25%     
+ Complexity     4753     4335     -418     
============================================
  Files           631      587      -44     
  Lines         23237    20636    -2601     
  Branches       3421     3118     -303     
============================================
- Hits          18028    16062    -1966     
+ Misses         3782     3276     -506     
+ Partials       1427     1298     -129     
Impacted Files Coverage Δ Complexity Δ
...nts/support/locale/LocaleAwareAppCompatActivity.kt 77.77% <100.00%> (+6.34%) 7.00 <5.00> (+3.00)
...onents/support/sync/telemetry/BaseGleanSyncPing.kt 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)
...ava/mozilla/components/support/migration/Result.kt
...mponents/browser/toolbar/internal/ActionWrapper.kt
.../mozilla/components/support/migration/Exception.kt
...ponents/support/migration/state/MigrationAction.kt
...a/components/browser/toolbar/display/MenuButton.kt
...a/components/browser/toolbar/display/OriginView.kt
...n/java/mozilla/components/concept/fetch/Request.kt
...n/java/mozilla/components/concept/fetch/Headers.kt
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b8f8e...f339c33. Read the comment docs.

@psymoon
Copy link
Contributor

psymoon commented May 1, 2020

bors r+

@bors
Copy link

bors bot commented May 1, 2020

Build succeeded:

@bors bors bot merged commit c9ac872 into mozilla-mobile:master May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants