[Bug] (regression) changing language requires an app restart now

[cadeyrn]

Steps to reproduce

1. change the language within Fenix

Expected behavior

The change applies immediately, as before 5202c0a.

Actual behavior

You have to restart Fenix to see the change of the language. It's a regression from the appcompat update in 5202c0a.

But good news is that the update fixed #7559 - an app start is also required in this case, but it's much better than a feature that is not working at all.

/cc @eliserichards @ekager

Device information

• Android device: OnePlus 7T Pro McLaren Edition, OxygenOS 10.0.7 (Android 10)
• Fenix version: master branch revision 40ba433

┆Issue is synchronized with this Jira Task

[Diana-Rus]

Hi, I confirm issue on FIrefox Preview Nightly 200326 (Build #20860605) GV: 76.0a1-20200324093140 with:

• Google Pixel 3 XL (Android 9)
  

• Samsung Galaxy S9 (Android 8)

• Sony Xperia Z5 (Android 7)

[liuche]

This should be fixed by mozilla-mobile/android-components#6517, which landed earlier, so it will probably be in the next AC nightly version that gets pulled into fenix.

[cadeyrn]

This is working for me now.

[lobontiumira]

Hi all,

This is not entirely fixed yet.

• In Fenix, I've set the language to Arabic/Urdu (or any RTL language), the language changed as expected in the app.
• Change back to follow the device's language, the app remained stuck between languages, meaning the language is changed, but the app is stuck in the RTL position.
• If Fenix is in the background and reopened, nothing changes.
• If Fenix is closed and reopened, it is working as expected again.

Device information:

• Android devices: HTC 10 (Android 8), Samsung Galaxy S9 (Android 8), and Motorola G6 (Android 8),
• Fenix version: Nightly build from 4/8
• Not reproducible on Google Pixel (Android 10), OnePlus 5T (Android 9), Sony Xperia Z5 Premium (Android 7.1.1), Samsung Galaxy Tab A6 (Android 5.1.1), OnePlus A3 (Android 6.0.1), LG g7 fit (Android 8.1)

I'll remove the qa:needed label.
Please see the attached GIF for better understanding:

[liuche]

That's definitely kind of weird behavior. @boek what do you think, since it's on a few devices (and I assume for RTL switching back and forth) do you want to file this as a follow-up, or try to fix it here?

[boek]

@liuche I think we should try to fix. It looks like it's an entire Android version

[ebalazs-sv]

This is reproducible on Fenix Beta 4.3.0-beta.1 from 4/14 with Motorola Moto G6 (Android 8).

[boek]

This needs QA in 4.3. Once mozilla-mobile/android-components#6690 lands we can test on Nightly

[lobontiumira]

Hi all!

The issue regarding RTL languages is still reproducible on Nightly build from 4/21 on HTC 10 (Android8), LG G7 Fit (Android 8.1), and Samsung Galaxy S9 (Android 8) - please see the GIF below taken with HTC device:

On HTC 10, and Samsung Galaxy S9, the issue is fixed on Beta 4.3.0-beta.2 - please see the GIF below:

However, on LG G7 Fit (Android 8.1) is not fixed yet, on Beta 4.3.0-beta.2 - please see the GIF below:

I'll remove the qa:needed flag for now.

[sv-sdeiac]

Hi, this issue is still reproducible using the latest version of Firefox Preview Nightly 4/30 #21210606.

Device:

• LG G7 fit (Android 8.1).

I'll remove the qa:needed flag till new updates are coming.

[boek]

🤦 will be fixed with mozilla-mobile/android-components#6834

[liuche]

This should have landed in Nightly by now since that AC issue is fixed and merged, so adding the QA-needed label again.

[lobontiumira]

Verified as fixed on the latest Nightly build from 5/18 with HTC 10 (Android 8), and LG G7 Fit (Android 8.1).