Bumps Application Services to v62.0.0 #7694

tarikeshaq · 2020-07-13T17:44:32Z

Connects to mozilla/application-services#3337
Bumps Application Services to 62.0.0

v62.0.0 (2020-07-13)

Full Changelog

FxA Client

⚠️ Breaking changes ⚠️

Adds support for entrypoint in oauth flow APIs: consumers of beginOAuthFlow and beginPairingFlow (beginAuthentication and beginPairingAuthentication in ios) are now required to pass an entrypoint argument that would be used for metrics. This puts the beginOAuthFlow and beginPairingFlow APIs inline with other existing APIs, like getManageAccountUrl. (#3265)
Changes the authorizeOAuthCode API to now accept an AuthorizationParams object instead of the individual parameters. The AuthorizationParams also includes optional AuthorizationPKCEParams that contain the codeChallenge, codeChallengeMethod. AuthorizationParams also includes an optional keysJwk for requesting keys (#3264)

What's new

Consumers can now optionally include parameters for metrics in beginOAuthFlow and beginPairingFlow (beginAuthentication and beginPairingAuthentication in ios). Those parameters can be passed in using a MetricsParams struct/class. MetricsParams is defined in both the Kotlin and Swift bindings. The parameters are the following (#3328):
- flow_id
- flow_begin_time
- device_id
- utm_source
- utm_content
- utm_medium
- utm_term
- utm_campaign
- entrypoint_experiment
- entrypoint_variation

Logins

What's fixed

Fixed a bug where attempting to edit a login with an empty form_submit_url would incorrectly
reject the entry as invalid (#3331).

Tabs

What's new

Tab records now have an explicit TTL set when storing on the server, to match the behaviour
of Firefox Desktop clients (#3322).

tarikeshaq · 2020-07-13T17:45:39Z

...ents/service/firefox-accounts/src/main/java/mozilla/components/service/fxa/FirefoxAccount.kt

            val state = Uri.parse(url).getQueryParameter("state")!!
            AuthFlowUrl(state, url)
        }
    }

    override fun beginPairingFlowAsync(pairingUrl: String, scopes: Set<String>) = scope.async {
        handleFxaExceptions(logger, "begin oauth pairing flow", { null }) {
-            val url = inner.beginPairingFlow(pairingUrl, scopes.toTypedArray())
+            val url = inner.beginPairingFlow(pairingUrl, scopes.toTypedArray(), "notset")


Will create an issue for this, probably going to require upstream consumers to set the entrypoint.

Right. Adding a bit of context: FxA basically considers any attempt to load the login page without an entrypoint parameter to be a metrics bug, as we have no way of attributing the signin metrics for that flow back to a particular UI touchpoint. Making this a required argument surfaces that requirement to the application, so we probably don't want to paper over it at this level. (Although @grigoryk might prefer to paper over it here for a short period while considering the API implications).

If we do decide to temporarily hard-code a default entrypoint here, I suggest the string "none"; this is what FxA uses internally when you don't provide an explicit entrypoint value.

rfk · 2020-07-13T21:18:39Z

...ents/service/firefox-accounts/src/main/java/mozilla/components/service/fxa/FirefoxAccount.kt

@@ -140,7 +141,8 @@ class FirefoxAccount internal constructor(
        accessType: AccessType
    ) = scope.async {
        handleFxaExceptions(logger, "authorizeOAuthCode", { null }) {
-            inner.authorizeOAuthCode(clientId, scopes, state, accessType.msg)
+            val authParams = AuthorizationParams(clientId, scopes, state, accessType.msg)
+            inner.authorizeOAuthCode(authParams)


Not necessarily for this PR, but flagging for future consideration - we should consider pushing the AuthorizationParams abstraction up through the API layers here, so that callers of the higher-level API can pass all the new properties in a sensible way.

Agreed, we can do that in a follow-up.

rfk · 2020-07-13T21:21:17Z

...ents/service/firefox-accounts/src/main/java/mozilla/components/service/fxa/FirefoxAccount.kt

            val state = Uri.parse(url).getQueryParameter("state")!!
            AuthFlowUrl(state, url)
        }
    }

    override fun beginPairingFlowAsync(pairingUrl: String, scopes: Set<String>) = scope.async {
        handleFxaExceptions(logger, "begin oauth pairing flow", { null }) {
-            val url = inner.beginPairingFlow(pairingUrl, scopes.toTypedArray())
+            val url = inner.beginPairingFlow(pairingUrl, scopes.toTypedArray(), "notset")


Right. Adding a bit of context: FxA basically considers any attempt to load the login page without an entrypoint parameter to be a metrics bug, as we have no way of attributing the signin metrics for that flow back to a particular UI touchpoint. Making this a required argument surfaces that requirement to the application, so we probably don't want to paper over it at this level. (Although @grigoryk might prefer to paper over it here for a short period while considering the API implications).

jonalmeida · 2020-07-13T21:22:32Z

bors try

^ To run UI automation.

bors · 2020-07-13T22:06:53Z

try

Build succeeded:

complete-push

eliserichards · 2020-07-15T16:42:32Z

Ping! What's the timeline on getting this merged? 🙏 😉

grigoryk · 2020-07-15T17:11:01Z

@eliserichards should merge today, hopefully.

grigoryk

Filed #7729 so we're not blocking on the entrypoint stuff, and #7730 for the auth params bit.

I'll take this for a quick spin locally, and if it all looks good will merge.

grigoryk · 2020-07-15T17:12:28Z

...ents/service/firefox-accounts/src/main/java/mozilla/components/service/fxa/FirefoxAccount.kt

@@ -140,7 +141,8 @@ class FirefoxAccount internal constructor(
        accessType: AccessType
    ) = scope.async {
        handleFxaExceptions(logger, "authorizeOAuthCode", { null }) {
-            inner.authorizeOAuthCode(clientId, scopes, state, accessType.msg)
+            val authParams = AuthorizationParams(clientId, scopes, state, accessType.msg)
+            inner.authorizeOAuthCode(authParams)


Agreed, we can do that in a follow-up.

grigoryk · 2020-07-15T20:00:28Z

New plan: we'll land 61.0.9 first (with a logins crash fix and the metrics extension), and hopefully try to get it onto beta/nightly first.

That gives us time to actually do the API bits for this PR properly.

grigoryk · 2020-07-21T01:54:05Z

Closing this PR, I'll do a pass on this instead which will make the necessary API changes (#7729 , #7730 ).

tarikeshaq commented Jul 13, 2020

View reviewed changes

Amejia481 requested a review from grigoryk July 13, 2020 17:52

Amejia481 assigned grigoryk Jul 13, 2020

rfk reviewed Jul 13, 2020

View reviewed changes

bors bot pushed a commit that referenced this pull request Jul 13, 2020

Try #7694:

542ee0e

rfk mentioned this pull request Jul 14, 2020

Correctly handle "" in login validation. mozilla/application-services#3331

Merged

4 tasks

Bumps Application Services to v62.0.0

f1cb5d8

tarikeshaq force-pushed the a-s-62.0.0 branch from 526688f to f1cb5d8 Compare July 14, 2020 05:03

eliserichards mentioned this pull request Jul 14, 2020

For #10173: login duplicates and save mozilla-mobile/fenix#11208

Merged

4 tasks

grigoryk mentioned this pull request Jul 15, 2020

Surface entrypoint as part of the FxA API #7729

Closed

grigoryk approved these changes Jul 15, 2020

View reviewed changes

grigoryk added the do not land PRs that requires coordination before landing label Jul 15, 2020

thomcc mentioned this pull request Jul 15, 2020

Closes #7731: Update application-services to 61.0.10 #7734

Merged

4 tasks

eliserichards mentioned this pull request Jul 16, 2020

Logins with potential duplicates should be able to be edited mozilla-mobile/fenix#12651

Closed

grigoryk closed this Jul 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bumps Application Services to v62.0.0 #7694

Bumps Application Services to v62.0.0 #7694

tarikeshaq commented Jul 13, 2020 •

edited

tarikeshaq Jul 13, 2020

rfk Jul 13, 2020

rfk Jul 14, 2020

rfk Jul 13, 2020

grigoryk Jul 15, 2020

rfk Jul 13, 2020

jonalmeida commented Jul 13, 2020

bors bot commented Jul 13, 2020

eliserichards commented Jul 15, 2020

grigoryk commented Jul 15, 2020

grigoryk left a comment

grigoryk Jul 15, 2020

grigoryk commented Jul 15, 2020

grigoryk commented Jul 21, 2020

Bumps Application Services to v62.0.0 #7694

Bumps Application Services to v62.0.0 #7694

Conversation

tarikeshaq commented Jul 13, 2020 • edited

v62.0.0 (2020-07-13)

FxA Client

⚠️ Breaking changes ⚠️

What's new

Logins

What's fixed

Tabs

What's new

tarikeshaq Jul 13, 2020

Choose a reason for hiding this comment

rfk Jul 13, 2020

Choose a reason for hiding this comment

rfk Jul 14, 2020

Choose a reason for hiding this comment

rfk Jul 13, 2020

Choose a reason for hiding this comment

grigoryk Jul 15, 2020

Choose a reason for hiding this comment

rfk Jul 13, 2020

Choose a reason for hiding this comment

jonalmeida commented Jul 13, 2020

bors bot commented Jul 13, 2020

try

eliserichards commented Jul 15, 2020

grigoryk commented Jul 15, 2020

grigoryk left a comment

Choose a reason for hiding this comment

grigoryk Jul 15, 2020

Choose a reason for hiding this comment

grigoryk commented Jul 15, 2020

grigoryk commented Jul 21, 2020

tarikeshaq commented Jul 13, 2020 •

edited