Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Logins with potential duplicates should be able to be edited #12651

Closed
eliserichards opened this issue Jul 16, 2020 · 4 comments
Closed

Logins with potential duplicates should be able to be edited #12651

eliserichards opened this issue Jul 16, 2020 · 4 comments
Labels
Feature:Logins needs:ac Needs Android Component Work wontfix

Comments

@eliserichards
Copy link
Contributor

eliserichards commented Jul 16, 2020

Needs fix in app services:

Currently, if a duplicate is found when a saved login is being edited, then changes are not able to be saved because of the way it's being handled in app services. This is manifesting in "false" saves, where the user is able to save an edit but their changes disappear. We need to

  1. get the app services latest version where this case is handled correctly and get that merged into AC
  2. handle any new errors being thrown (if any) and make sure dupes are handled correctly when saving/showing errors to users.

Steps to reproduce an error

In about:logins on desktop:

  1. Create a new login:
    Website address: https://www.google.com
    Username: user1
    Password: lskdflsdkfjs
  2. Create a second login with the same web address:
    Website address: https://www.google.com
    Username: user2
    Password: sdkjfhksd
  3. Sync to get logins on Fenix

In Fenix:

  1. Navigate to saved logins in the Settings menu
  2. Open the newly created login and Edit the login
  3. Change username or password
  4. Save

┆Issue is synchronized with this Jira Task

@eliserichards eliserichards added needs:ac Needs Android Component Work Feature:Logins labels Jul 16, 2020
@eliserichards eliserichards self-assigned this Jul 16, 2020
@eliserichards
Copy link
Contributor Author

Confirmed with Grisha that the fix is in the latest master for A-C (app service v61.0.10)

@eliserichards
Copy link
Contributor Author

Waiting on #12669

@eliserichards eliserichards added 🙅 waiting Issues that are blocked or has dependencies that are not ready and removed needs:triage Issue needs triage labels Jul 17, 2020
@ekager
Copy link
Contributor

ekager commented Jul 21, 2020

Looks like the blocking pieces have landed?

@eliserichards eliserichards removed their assignment Jul 21, 2020
@eliserichards eliserichards removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jul 21, 2020
@data-sync-user data-sync-user changed the title Logins with potential duplicates should be able to be edited FNX3-21812 ⁃ Logins with potential duplicates should be able to be edited Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-21812 ⁃ Logins with potential duplicates should be able to be edited FNX-13753 ⁃ Logins with potential duplicates should be able to be edited Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13753 ⁃ Logins with potential duplicates should be able to be edited FNX2-15393 ⁃ Logins with potential duplicates should be able to be edited Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX2-15393 ⁃ Logins with potential duplicates should be able to be edited Logins with potential duplicates should be able to be edited Aug 29, 2020
@stale
Copy link

stale bot commented Feb 25, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 25, 2021
@stale stale bot closed this as completed Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature:Logins needs:ac Needs Android Component Work wontfix
Projects
None yet
Development

No branches or pull requests

2 participants