Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Make sure device finalization succeeds before proceeding to postAuth #7915

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Make sure device finalization succeeds before proceeding to postAuth #7915

merged 1 commit into from
Jul 30, 2020

Conversation

grigoryk
Copy link
Contributor

@grigoryk grigoryk commented Jul 29, 2020 •
edited
Loading

Closes #7536

Proper fix is coming in #7856, but this gets the crashes to go away.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@grigoryk grigoryk requested a review from csadilek July 29, 2020 19:58
@st3fan st3fan added the R79 label Jul 29, 2020
csadilek
csadilek approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@grigoryk
Copy link
Contributor Author

bors r=csadilek

bors bot pushed a commit that referenced this pull request Jul 29, 2020
@MozLando
Merge #7915
e83ca9f 
7915: Make sure device finalization succeeds before proceeding to postAuth r=csadilek a=grigoryk

Closes #7536 

Proper fix is coming in #7856, but this gets the crashes to go away.



Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
@bors
Copy link

bors bot commented Jul 30, 2020

Timed out.

@grigoryk
Copy link
Contributor Author

bors retry

@bors
Copy link

bors bot commented Jul 30, 2020

Build succeeded:

@bors bors bot merged commit d23dd9d into mozilla-mobile:master Jul 30, 2020
@grigoryk grigoryk deleted the postAuthQr branch July 30, 2020 05:12
@pocmo
Copy link
Contributor

pocmo commented Jul 30, 2020

Uplifted to 48.0.

@liuche liuche added the R80 label Jul 31, 2020
@pocmo
Copy link
Contributor

pocmo commented Jul 31, 2020

Uplifted to 52.

@pocmo pocmo removed R79 labels Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csadilek csadilek csadilek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@grigoryk @pocmo @csadilek @st3fan @liuche