This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
SessionStorage: Write state as stream to disk instead of building model in memory first. #8358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocmo
force-pushed
the
7886-outofmemory
branch
from
c995538
to
27c961d
Compare
Amejia481
reviewed
Sep 9, 2020
| @@ -18,5 +19,14 @@ interface EngineSessionState { | |||
| * When reading JSON from disk [Engine.createSessionState] can be used to turn it back into an [EngineSessionState] | |||
| * instance. | |||
| */ | |||
| @Deprecated("Use writeTo() instead.") | |||
There was a problem hiding this comment.
nit: Should we also include when this will be deleted?
There was a problem hiding this comment.
I didn't want to have a fixed date for removing this since we first need time to migrate some of our own components code over. My primary goal was to avoid any new code using this. :)
But I filed a new issue for eventually migrating everything and will also link this in a comment: #8370
pocmo
force-pushed
the
7886-outofmemory
branch
from
27c961d
to
582433d
Compare
|
bors r=Amejia481 |
|
bors r- |
|
Canceled. |
…hen writing to disk and log error.
pocmo
force-pushed
the
7886-outofmemory
branch
from
582433d
to
18774d2
Compare
|
bors r=Amejia481 |
bors bot
pushed a commit
that referenced
this pull request
Sep 11, 2020
8358: SessionStorage: Write state as stream to disk instead of building model in memory first. r=Amejia481 a=pocmo With this change we are using `JsonWriter` to write `BrowserState` directly to disk using a stream. Previously we first build a `JSONObject` tree in memory. This essentially duplicates the state and that could become big if a user had a lot of tabs open and not much RAM. Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
|
Build failed: |
pocmo
force-pushed
the
7886-outofmemory
branch
from
18774d2
to
29fb030
Compare
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Sep 11, 2020
8358: SessionStorage: Write state as stream to disk instead of building model in memory first. r=Amejia481 a=pocmo With this change we are using `JsonWriter` to write `BrowserState` directly to disk using a stream. Previously we first build a `JSONObject` tree in memory. This essentially duplicates the state and that could become big if a user had a lot of tabs open and not much RAM. Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
|
Build failed: |
…disk instead of building model in memory first.
pocmo
force-pushed
the
7886-outofmemory
branch
from
29fb030
to
443d6a1
Compare
|
bors retry |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we are using
JsonWriterto writeBrowserStatedirectly to disk using a stream. Previously we first build aJSONObjecttree in memory. This essentially duplicates the state and that could become big if a user had a lot of tabs open and not much RAM.