Adjust detekt TooManyFunctions threshold

components/browser/awesomebar/src/main/java/mozilla/components/browser/awesomebar/BrowserAwesomeBar.kt

@@ -33,7 +33,7 @@ internal const val INITIAL_NUMBER_OF_PROVIDERS = 5
 /**
  * A customizable [AwesomeBar] implementation.
  */
-@Suppress("TooManyFunctions", "LargeClass")
+@Suppress("LargeClass")
 class BrowserAwesomeBar @JvmOverloads constructor(
     context: Context,
     attrs: AttributeSet? = null,

components/browser/engine-gecko-beta/src/androidTest/java/mozilla/components/browser/engine/gecko/fetch/geckoview/GeckoViewFetchTestCases.kt

@@ -13,7 +13,6 @@ import org.junit.Assert.assertTrue
 import org.junit.Test
 
 @MediumTest
-@Suppress("TooManyFunctions")
 class GeckoViewFetchTestCases : mozilla.components.tooling.fetch.tests.FetchTestCases() {
     override fun createNewClient(): Client = GeckoViewFetchClient(ApplicationProvider.getApplicationContext())
 

components/browser/engine-gecko-beta/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngine.kt

@@ -65,7 +65,7 @@ import java.lang.ref.WeakReference
 /**
  * Gecko-based implementation of Engine interface.
  */
-@Suppress("TooManyFunctions", "LargeClass")
+@Suppress("LargeClass")
 class GeckoEngine(
     context: Context,
     private val defaultSettings: Settings? = null,

components/browser/engine-gecko-beta/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineView.kt

@@ -24,7 +24,6 @@ import org.mozilla.geckoview.GeckoSession
 /**
  * Gecko-based EngineView implementation.
  */
-@Suppress("TooManyFunctions")
 class GeckoEngineView @JvmOverloads constructor(
     context: Context,
     attrs: AttributeSet? = null,

components/browser/engine-gecko-beta/src/main/java/mozilla/components/browser/engine/gecko/NestedGeckoView.kt

@@ -26,7 +26,7 @@ import org.mozilla.geckoview.PanZoomController.INPUT_RESULT_UNHANDLED
  * https://github.com/takahirom/webview-in-coordinatorlayout
  */
 
-@Suppress("TooManyFunctions", "ClickableViewAccessibility")
+@Suppress("ClickableViewAccessibility")
 open class NestedGeckoView(context: Context) : GeckoView(context), NestedScrollingChild {
 
     @VisibleForTesting

components/browser/engine-gecko-beta/src/main/java/mozilla/components/browser/engine/gecko/prompt/GeckoPromptDelegate.kt

@@ -54,7 +54,6 @@ typealias AC_FILE_FACING_MODE = PromptRequest.File.FacingMode
 /**
  * Gecko-based PromptDelegate implementation.
  */
-@Suppress("TooManyFunctions")
 internal class GeckoPromptDelegate(private val geckoEngineSession: GeckoEngineSession) :
     PromptDelegate {
 

components/browser/engine-gecko-beta/src/main/java/mozilla/components/browser/engine/gecko/webextension/GeckoWebExtension.kt

@@ -31,7 +31,6 @@ import org.mozilla.geckoview.WebExtension.Action as GeckoNativeWebExtensionActio
  * Gecko-based implementation of [WebExtension], wrapping the native web
  * extension object provided by GeckoView.
  */
-@Suppress("TooManyFunctions")
 class GeckoWebExtension(
     val nativeExtension: GeckoNativeWebExtension,
     val runtime: GeckoRuntime

components/browser/engine-gecko-nightly/src/androidTest/java/mozilla/components/browser/engine/gecko/fetch/geckoview/GeckoViewFetchTestCases.kt

@@ -13,7 +13,6 @@ import org.junit.Assert.assertTrue
 import org.junit.Test
 
 @MediumTest
-@Suppress("TooManyFunctions")
 class GeckoViewFetchTestCases : mozilla.components.tooling.fetch.tests.FetchTestCases() {
     override fun createNewClient(): Client = GeckoViewFetchClient(ApplicationProvider.getApplicationContext())
 

components/browser/engine-gecko-nightly/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngine.kt

@@ -65,7 +65,7 @@ import java.lang.ref.WeakReference
 /**
  * Gecko-based implementation of Engine interface.
  */
-@Suppress("TooManyFunctions", "LargeClass")
+@Suppress("LargeClass")
 class GeckoEngine(
     context: Context,
     private val defaultSettings: Settings? = null,

components/browser/engine-gecko-nightly/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineView.kt

@@ -24,7 +24,6 @@ import org.mozilla.geckoview.GeckoSession
 /**
  * Gecko-based EngineView implementation.
  */
-@Suppress("TooManyFunctions")
 class GeckoEngineView @JvmOverloads constructor(
     context: Context,
     attrs: AttributeSet? = null,

components/browser/engine-gecko-nightly/src/main/java/mozilla/components/browser/engine/gecko/NestedGeckoView.kt

@@ -26,7 +26,7 @@ import org.mozilla.geckoview.PanZoomController.INPUT_RESULT_UNHANDLED
  * https://github.com/takahirom/webview-in-coordinatorlayout
  */
 
-@Suppress("TooManyFunctions", "ClickableViewAccessibility")
+@Suppress("ClickableViewAccessibility")
 open class NestedGeckoView(context: Context) : GeckoView(context), NestedScrollingChild {
 
     @VisibleForTesting

components/browser/engine-gecko-nightly/src/main/java/mozilla/components/browser/engine/gecko/prompt/GeckoPromptDelegate.kt

@@ -54,7 +54,6 @@ typealias AC_FILE_FACING_MODE = PromptRequest.File.FacingMode
 /**
  * Gecko-based PromptDelegate implementation.
  */
-@Suppress("TooManyFunctions")
 internal class GeckoPromptDelegate(private val geckoEngineSession: GeckoEngineSession) :
     PromptDelegate {
 

components/browser/engine-gecko-nightly/src/main/java/mozilla/components/browser/engine/gecko/webextension/GeckoWebExtension.kt

@@ -31,7 +31,6 @@ import org.mozilla.geckoview.WebExtension.Action as GeckoNativeWebExtensionActio
  * Gecko-based implementation of [WebExtension], wrapping the native web
  * extension object provided by GeckoView.
  */
-@Suppress("TooManyFunctions")
 class GeckoWebExtension(
     val nativeExtension: GeckoNativeWebExtension,
     val runtime: GeckoRuntime

components/browser/engine-gecko/src/androidTest/java/mozilla/components/browser/engine/gecko/fetch/geckoview/GeckoViewFetchTestCases.kt

@@ -13,7 +13,6 @@ import org.junit.Assert.assertTrue
 import org.junit.Test
 
 @MediumTest
-@Suppress("TooManyFunctions")
 class GeckoViewFetchTestCases : mozilla.components.tooling.fetch.tests.FetchTestCases() {
     override fun createNewClient(): Client = GeckoViewFetchClient(ApplicationProvider.getApplicationContext())
 

components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngine.kt

@@ -65,7 +65,7 @@ import java.lang.ref.WeakReference
 /**
  * Gecko-based implementation of Engine interface.
  */
-@Suppress("TooManyFunctions", "LargeClass")
+@Suppress("LargeClass")
 class GeckoEngine(
     context: Context,
     private val defaultSettings: Settings? = null,

components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineView.kt

@@ -24,7 +24,6 @@ import org.mozilla.geckoview.GeckoSession
 /**
  * Gecko-based EngineView implementation.
  */
-@Suppress("TooManyFunctions")
 class GeckoEngineView @JvmOverloads constructor(
     context: Context,
     attrs: AttributeSet? = null,

components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/NestedGeckoView.kt

@@ -26,7 +26,7 @@ import org.mozilla.geckoview.PanZoomController.INPUT_RESULT_UNHANDLED
  * https://github.com/takahirom/webview-in-coordinatorlayout
  */
 
-@Suppress("TooManyFunctions", "ClickableViewAccessibility")
+@Suppress("ClickableViewAccessibility")
 open class NestedGeckoView(context: Context) : GeckoView(context), NestedScrollingChild {
 
     @VisibleForTesting

components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/prompt/GeckoPromptDelegate.kt

@@ -54,7 +54,6 @@ typealias AC_FILE_FACING_MODE = PromptRequest.File.FacingMode
 /**
  * Gecko-based PromptDelegate implementation.
  */
-@Suppress("TooManyFunctions")
 internal class GeckoPromptDelegate(private val geckoEngineSession: GeckoEngineSession) :
     PromptDelegate {
 

components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/webextension/GeckoWebExtension.kt

@@ -31,7 +31,6 @@ import org.mozilla.geckoview.WebExtension.Action as GeckoNativeWebExtensionActio
  * Gecko-based implementation of [WebExtension], wrapping the native web
  * extension object provided by GeckoView.
  */
-@Suppress("TooManyFunctions")
 class GeckoWebExtension(
     val nativeExtension: GeckoNativeWebExtension,
     val runtime: GeckoRuntime

components/browser/engine-system/src/main/java/mozilla/components/browser/engine/system/NestedWebView.kt

@@ -29,8 +29,6 @@ import mozilla.components.concept.engine.EngineView
  * Based on:
  * https://github.com/takahirom/webview-in-coordinatorlayout
  */
-
-@Suppress("TooManyFunctions")
 class NestedWebView(context: Context) : WebView(context), NestedScrollingChild {
 
     @VisibleForTesting

components/browser/search/src/main/java/mozilla/components/browser/search/SearchEngineManager.kt

@@ -24,7 +24,6 @@ import kotlin.coroutines.CoroutineContext
 /**
  * This class provides access to a centralized registry of search engines.
  */
-@Suppress("TooManyFunctions")
 class SearchEngineManager(
     private val providers: List<SearchEngineProvider> = listOf(
             AssetsSearchEngineProvider(LocaleSearchLocalizationProvider())),

components/browser/search/src/main/java/mozilla/components/browser/search/provider/AssetsSearchEngineProvider.kt

@@ -33,7 +33,7 @@ import org.json.JSONObject
  * Optionally <code>additionalIdentifiers</code> to be loaded can be specified. A search engine
  * identifier corresponds to the search plugin XML file name (e.g. duckduckgo -> duckduckgo.xml).
  */
-@Suppress("TooManyFunctions", "LargeClass")
+@Suppress("LargeClass")
 class AssetsSearchEngineProvider(
     private val localizationProvider: SearchLocalizationProvider,
     private val filters: List<SearchEngineFilter> = emptyList(),

components/browser/session/src/main/java/mozilla/components/browser/session/LegacySessionManager.kt

@@ -16,7 +16,7 @@ import kotlin.math.min
 /**
  * This class provides access to a centralized registry of all active sessions.
  */
-@Suppress("TooManyFunctions", "LargeClass")
+@Suppress("LargeClass")
 class LegacySessionManager(
     val engine: Engine,
     delegate: DeprecatedObserverRegistry<SessionManager.Observer> = DeprecatedObserverRegistry()

components/browser/session/src/main/java/mozilla/components/browser/session/Session.kt

@@ -34,7 +34,7 @@ import kotlin.properties.Delegates
 /**
  * Value type that represents the state of a browser session. Changes can be observed.
  */
-@Suppress("TooManyFunctions", "LongParameterList")
+@Suppress("LongParameterList")
 class Session(
     initialUrl: String,
     val private: Boolean = false,

components/browser/session/src/main/java/mozilla/components/browser/session/SessionManager.kt

@@ -33,7 +33,7 @@ import mozilla.components.support.base.observer.DeprecatedObservable
 /**
  * This class provides access to a centralized registry of all active sessions.
  */
-@Suppress("TooManyFunctions", "LargeClass")
+@Suppress("LargeClass")
 class SessionManager(
     val engine: Engine,
     private val store: BrowserStore? = null,

components/browser/session/src/main/java/mozilla/components/browser/session/engine/middleware/EngineDelegateMiddleware.kt

@@ -25,7 +25,6 @@ import mozilla.components.support.base.log.logger.Logger
  * [Middleware] responsible for delegating calls to the appropriate [EngineSession] instance for
  * actions like [EngineAction.LoadUrlAction].
  */
-@Suppress("TooManyFunctions")
 internal class EngineDelegateMiddleware(
     private val engine: Engine,
     private val sessionLookup: (String) -> Session?,

components/browser/storage-memory/src/main/java/mozilla/components/browser/storage/memory/InMemoryHistoryStorage.kt

@@ -25,7 +25,6 @@ const val AUTOCOMPLETE_SOURCE_NAME = "memoryHistory"
 /**
  * An in-memory implementation of [mozilla.components.concept.storage.HistoryStorage].
  */
-@SuppressWarnings("TooManyFunctions")
 class InMemoryHistoryStorage : HistoryStorage {
     @VisibleForTesting
     internal var pages: HashMap<String, MutableList<Visit>> = linkedMapOf()

components/browser/storage-sync/src/main/java/mozilla/components/browser/storage/sync/Connection.kt

@@ -61,7 +61,6 @@ internal interface Connection : Closeable {
 /**
  * A singleton implementation of the [Connection] interface backed by the Rust Places library.
  */
-@Suppress("TooManyFunctions")
 internal object RustPlacesConnection : Connection {
     @GuardedBy("this")
     private var api: PlacesApi? = null

components/browser/storage-sync/src/main/java/mozilla/components/browser/storage/sync/PlacesBookmarksStorage.kt

@@ -21,7 +21,6 @@ import org.json.JSONObject
 /**
  * Implementation of the [BookmarksStorage] which is backed by a Rust Places lib via [PlacesApi].
  */
-@Suppress("TooManyFunctions")
 open class PlacesBookmarksStorage(context: Context) : PlacesStorage(context), BookmarksStorage, SyncableStore {
 
     override val logger = Logger("PlacesBookmarksStorage")

components/browser/storage-sync/src/main/java/mozilla/components/browser/storage/sync/PlacesHistoryStorage.kt

@@ -32,7 +32,6 @@ const val AUTOCOMPLETE_SOURCE_NAME = "placesHistory"
 /**
  * Implementation of the [HistoryStorage] which is backed by a Rust Places lib via [PlacesApi].
  */
-@SuppressWarnings("TooManyFunctions")
 open class PlacesHistoryStorage(
     context: Context,
     crashReporter: CrashReporting? = null

components/browser/tabstray/src/main/java/mozilla/components/browser/tabstray/TabsAdapter.kt

@@ -25,7 +25,6 @@ typealias ViewHolderProvider = (ViewGroup) -> TabViewHolder
  * @param viewHolderProvider a function that creates a `TabViewHolder`.
  * @param delegate TabsTray.Observer registry to allow `TabsAdapter` to conform to `Observable<TabsTray.Observer>`.
  */
-@Suppress("TooManyFunctions")
 open class TabsAdapter(
     thumbnailLoader: ImageLoader? = null,
     private val viewHolderProvider: ViewHolderProvider = { parent ->

components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/BrowserToolbar.kt

@@ -59,7 +59,6 @@ const val MAX_URI_LENGTH = 25000
  *  +----------------+ +----------------+
  * ```
  */
-@Suppress("TooManyFunctions")
 class BrowserToolbar @JvmOverloads constructor(
     context: Context,
     attrs: AttributeSet? = null,

components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/behavior/BrowserToolbarBehavior.kt

@@ -38,7 +38,6 @@ enum class ToolbarPosition {
  * - On showing a [Snackbar] position it above the [BrowserToolbar].
  * - Snap the [BrowserToolbar] to be hidden or visible when the user stops scrolling.
  */
-@Suppress("TooManyFunctions")
 class BrowserToolbarBehavior(
     val context: Context?,
     attrs: AttributeSet?,

components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/display/DisplayToolbar.kt

@@ -65,7 +65,7 @@ import mozilla.components.concept.toolbar.Toolbar
  * Progress (optional):
  *     A horizontal progress bar showing the loading progress (at the top or bottom of the toolbar).
  */
-@Suppress("LargeClass", "TooManyFunctions")
+@Suppress("LargeClass")
 class DisplayToolbar internal constructor(
     private val context: Context,
     private val toolbar: BrowserToolbar,

components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/edit/EditToolbar.kt

@@ -50,7 +50,7 @@ private const val AUTOCOMPLETE_QUERY_THREADS = 3
  * - actions: Optional action icons injected by other components (e.g. barcode scanner)
  * - exit: Button that switches back to display mode or invoke an app-defined callback.
  */
-@Suppress("TooManyFunctions", "LargeClass")
+@Suppress("LargeClass")
 class EditToolbar internal constructor(
     context: Context,
     private val toolbar: BrowserToolbar,

components/concept/engine/src/main/java/mozilla/components/concept/engine/DataCleanable.kt

@@ -7,7 +7,6 @@ package mozilla.components.concept.engine
 /**
  * Contract to indicate how objects with the ability to clear data should behave.
  */
-@Suppress("TooManyFunctions")
 interface DataCleanable {
     /**
      * Clears browsing data stored.

components/concept/engine/src/main/java/mozilla/components/concept/engine/Engine.kt

@@ -22,7 +22,6 @@ import org.json.JSONObject
 /**
  * Entry point for interacting with the engine implementation.
  */
-@Suppress("TooManyFunctions")
 interface Engine : WebExtensionRuntime, DataCleanable {
 
     /**

components/concept/engine/src/main/java/mozilla/components/concept/engine/EngineView.kt

@@ -13,7 +13,6 @@ import mozilla.components.concept.engine.selection.SelectionActionDelegate
 /**
  * View component that renders web content.
  */
-@Suppress("TooManyFunctions")
 interface EngineView {
 
     /**

components/concept/engine/src/main/java/mozilla/components/concept/engine/manifest/WebAppManifestParser.kt

@@ -2,8 +2,6 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-@file:Suppress("TooManyFunctions")
-
 package mozilla.components.concept.engine.manifest
 
 import android.graphics.Color

components/concept/engine/src/main/java/mozilla/components/concept/engine/manifest/parser/WebAppManifestIconParser.kt

@@ -2,8 +2,6 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-@file:Suppress("TooManyFunctions")
-
 package mozilla.components.concept.engine.manifest.parser
 
 import mozilla.components.concept.engine.manifest.Size

components/concept/engine/src/main/java/mozilla/components/concept/engine/webextension/WebExtension.kt

@@ -20,7 +20,6 @@ import org.json.JSONObject
  * @property supportActions whether or not browser and page actions are handled when
  * received from the web extension
  */
-@Suppress("TooManyFunctions")
 abstract class WebExtension(
     val id: String,
     val url: String,

components/concept/engine/src/main/java/mozilla/components/concept/engine/webextension/WebExtensionDelegate.kt

@@ -11,7 +11,6 @@ import mozilla.components.concept.engine.EngineSession
  * extensions e.g. an extension was installed, or an extension wants to open
  * a new tab.
  */
-@Suppress("TooManyFunctions")
 interface WebExtensionDelegate {
 
     /**

components/concept/storage/src/main/java/mozilla/components/concept/storage/CreditCardsAddressesStorage.kt

@@ -9,7 +9,6 @@ import kotlinx.coroutines.Deferred
 /**
  * An interface which defines read/write methods for credit card and address data.
  */
-@SuppressWarnings("TooManyFunctions")
 interface CreditCardsAddressesStorage {
 
     /**

components/concept/storage/src/main/java/mozilla/components/concept/storage/HistoryStorage.kt

@@ -7,7 +7,6 @@ package mozilla.components.concept.storage
 /**
  * An interface which defines read/write methods for history data.
  */
-@SuppressWarnings("TooManyFunctions")
 interface HistoryStorage : Storage {
     /**
      * Records a visit to a page.

components/concept/storage/src/main/java/mozilla/components/concept/storage/LoginsStorage.kt

@@ -10,7 +10,6 @@ import org.json.JSONObject
 /**
  * An interface describing a storage layer for logins/passwords.
  */
-@SuppressWarnings("TooManyFunctions")
 interface LoginsStorage : AutoCloseable {
     /**
      * Deletes all login records. These deletions will be synced to the server on the next call to sync.

components/concept/sync/src/main/java/mozilla/components/concept/sync/Devices.kt

@@ -1,7 +1,7 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-@file:SuppressWarnings("TooManyFunctions")
+
 package mozilla.components.concept.sync
 
 import android.content.Context

components/concept/sync/src/main/java/mozilla/components/concept/sync/OAuthAccount.kt

@@ -43,7 +43,6 @@ data class MigratingAccountInfo(
 /**
  * Facilitates testing consumers of FirefoxAccount.
  */
-@SuppressWarnings("TooManyFunctions")
 interface OAuthAccount : AutoCloseable {
 
     /**