Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Adjust detekt TooManyFunctions threshold #9927

Merged
merged 2 commits into from Mar 18, 2021

Conversation

csadilek
Copy link
Contributor

Looking at the 94 :) @Suppress affected by this, we wouldn't actually ever do anything about those. Having <=25 methods in an interface or class seems fine, imo. I played with different values here and this seems like a good trade-off e.g. SystemEngineView still triggers a warning.

Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #9927 (8c824e3) into master (2481473) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9927      +/-   ##
============================================
+ Coverage     74.00%   74.11%   +0.11%     
+ Complexity     5666     2428    -3238     
============================================
  Files           778      359     -419     
  Lines         28828    12025   -16803     
  Branches       4743     2035    -2708     
============================================
- Hits          21333     8912   -12421     
+ Misses         5011     2043    -2968     
+ Partials       2484     1070    -1414     
Impacted Files Coverage Δ Complexity Δ
...components/browser/awesomebar/BrowserAwesomeBar.kt 91.17% <ø> (ø) 35.00 <0.00> (ø)
.../components/browser/engine/system/NestedWebView.kt 86.36% <ø> (ø) 17.00 <0.00> (ø)
...a/components/browser/search/SearchEngineManager.kt 78.43% <ø> (ø) 24.00 <0.00> (ø)
...wser/search/provider/AssetsSearchEngineProvider.kt 92.55% <ø> (ø) 31.00 <0.00> (ø)
...components/browser/session/LegacySessionManager.kt 92.96% <ø> (ø) 72.00 <0.00> (ø)
...java/mozilla/components/browser/session/Session.kt 94.91% <ø> (ø) 20.00 <0.00> (ø)
...zilla/components/browser/session/SessionManager.kt 85.23% <ø> (ø) 55.00 <0.00> (ø)
...sion/engine/middleware/EngineDelegateMiddleware.kt 78.21% <ø> (ø) 22.00 <0.00> (ø)
...s/browser/storage/memory/InMemoryHistoryStorage.kt 84.50% <ø> (ø) 28.00 <0.00> (ø)
...illa/components/browser/storage/sync/Connection.kt 54.05% <ø> (ø) 0.00 <0.00> (ø)
... and 403 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2481473...8c824e3. Read the comment docs.

Copy link
Contributor

@rfk rfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, I strongly support changing/removing warnings that we're in the habit of ignoring, with the amount of @Suppress churn here seems to suggest we were :-)

@csadilek csadilek added the 🛬 needs landing PRs that are ready to land label Mar 18, 2021
@mergify mergify bot merged commit 3b268f9 into mozilla-mobile:master Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants