Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Commit

Permalink
Added color for "Share" menu's "Recently Used" in Dark theme
Browse files Browse the repository at this point in the history
- Created a separate attribute recentlyUsedSharedMenu to be used by 'recently used' panel of tab share menu
- It specifies colors to be used for Light and Dark theme
  • Loading branch information
neha-b2001 committed Apr 28, 2021
1 parent 4028152 commit 7f9165d
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/src/main/res/drawable/recent_apps_background.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<shape xmlns:android="http://schemas.android.com/apk/res/android">
<solid android:color="?inset"/>
<solid android:color="?recentlyUsedShareMenu"/>
<corners android:radius="@dimen/share_recent_apps_background_radius"/>
</shape>
1 change: 1 addition & 0 deletions app/src/main/res/values-night/colors.xml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
<color name="preference_section_header_normal_theme">@color/preference_section_header_dark_theme</color>
<color name="notification_accent_color_normal_theme">@color/accent_high_contrast_dark_theme</color>
<color name="menu_item_button_normal_theme">@color/accent_high_contrast_dark_theme</color>
<color name="recently_used_share_theme">@color/recently_used_share_menu_dark_theme</color>

<color name="mozac_widget_favicon_background_normal_theme">@color/mozac_widget_favicon_background_dark_theme</color>
<color name="mozac_widget_favicon_border_normal_theme">@color/mozac_widget_favicon_border_dark_theme</color>
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/attrs.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
<attr name="toolbarDivider" format="reference"/>
<attr name="menuCategoryText" format="reference"/>
<attr name="preferenceSectionHeader" format="reference"/>
<attr name="recentlyUsedShareMenu" format="reference" />

<!-- Color used in DefaultToolbarMenu for buttons placed at the end of menu items -->
<attr name="menuItemButtonTintColor" format="reference"/>
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/res/values/colors.xml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
<color name="contrast_text_dark_theme">@color/primary_text_dark_theme</color>
<color name="caption_text_dark_theme">@color/photonLightGrey70</color>
<color name="foundation_dark_theme">#1C1B22</color>
<color name="inset_dark_theme">@color/photonDarkGrey10</color>
<color name="inset_dark_theme">#32313C</color>
<color name="above_dark_theme">#32313C</color>
<color name="accent_dark_theme">#9059FF</color>
<color name="accent_bright_dark_theme">#592ACB</color>
Expand Down Expand Up @@ -123,6 +123,7 @@
<color name="search_suggestion_indicator_icon_color_dark_theme">#2ac3a2</color>
<color name="search_suggestion_indicator_icon_bookmark_color_dark_theme">#0090ed</color>
<color name="preference_section_header_dark_theme">@color/accent_high_contrast_dark_theme</color>
<color name="recently_used_share_menu_dark_theme">@color/photonDarkGrey10</color>

<color name="mozac_widget_favicon_background_dark_theme">@color/photonDarkGrey50</color>
<color name="mozac_widget_favicon_border_dark_theme">@color/photonDarkGrey10</color>
Expand Down Expand Up @@ -251,6 +252,7 @@
<color name="mozac_widget_favicon_border_normal_theme">@color/mozac_widget_favicon_border_light_theme</color>
<color name="notification_accent_color_normal_theme">@color/accent_bright_light_theme</color>
<color name="menu_item_button_normal_theme">@color/menu_item_button_light_theme</color>
<color name="recently_used_share_theme">@color/inset_light_theme</color>

<!-- Tab tray -->
<color name="tab_tray_item_text_normal_theme">@color/tab_tray_item_text_light_theme</color>
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/styles.xml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
<item name="selectLoginHeaderTextColor">@color/select_login_header_normal_theme</item>
<item name="preferenceSectionHeader">@color/preference_section_header_normal_theme</item>
<item name="menuItemButtonTintColor">@color/menu_item_button_normal_theme</item>
<item name="recentlyUsedShareMenu">@color/recently_used_share_theme</item>

<!-- Shared widget colors -->
<item name="mozac_primary_text_color">@color/primary_text_normal_theme</item>
Expand Down

0 comments on commit 7f9165d

Please sign in to comment.