Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Settings for crash reporting #1003

Closed
vesta0 opened this issue Mar 13, 2019 · 6 comments
Closed

Settings for crash reporting #1003

vesta0 opened this issue Mar 13, 2019 · 6 comments

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Mar 13, 2019

User Story
As a user I have the option to enable/disable crash reporting in settings.

Dependencies (Added by PM and Eng)

Next Steps

  • Immediate task: Estimate/size user story with points (during backlog grooming)
  • Engineers need to breakdown the user story, size all the individual tasks, and link the tasks to this user story (Done by Eng on Sprint Planning day)

Acceptance Criteria (Added by PM)

  • I can enable/disable crash reporting in settings.
  • When I have disabled crash reporting, no reports are sent to Sentry
  • When I have disabled crash reporting, no reports are sent to Socorro
  • When I have disabled crash reporting, Fenix will never ask me to send a crash report

┆Issue is synchronized with this Jira Task

@sblatz
Copy link
Contributor

sblatz commented Mar 18, 2019

To confirm what this means:

Should this box just be unchecked if the user has switched their data preference for crash reporting off?

image

@sblatz sblatz self-assigned this Mar 18, 2019
@sblatz sblatz added 🙅 waiting Issues that are blocked or has dependencies that are not ready in progress eng:qa:needed QA Needed and removed in progress 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Mar 20, 2019
@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Mar 28, 2019

There is also a checkbox on the app crashed dialog:
Screenshot_20190328-082712
This should be removed/un-checked when the crash reporter is turned off.
*Note: there is no report sent to crash-stats.mozilla.com even if it's selected.

@sblatz
Copy link
Contributor

sblatz commented Mar 28, 2019

@sv-ohorvath I will create a follow-up bug for this.

@sv-ohorvath
Copy link
Contributor

Ok, so I can close this. Thanks!

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 29, 2019
@sblatz
Copy link
Contributor

sblatz commented Mar 29, 2019

@brampitoyo I think we will need to add the checkbox back and just default it to the state the user has in the settings (or remove the setting altogether).

Unfortunately removing the checkbox is not a trivial change as I anticipated, and after spending over a day working on it I discovered an issue with the way crash reporting is handled by GV/A-C that makes this change incredibly difficult and time consuming.

I am also concerned that user would be sending crash reports without knowing it since it would be buried deep in the settings, rather than asking users on each prompt since the data could be identifiable.

Please let me know if you'd like to chat about this more!

@brampitoyo
Copy link

@sblatz wrote:

Unfortunately removing the checkbox is not a trivial change as I anticipated

Adding the checkbox back in is fine by me. I have updated the mockup to suit: https://mozilla.invisionapp.com/share/P7R8W1ZWHM6

@data-sync-user data-sync-user changed the title Settings for crash reporting FNX2-15693 ⁃ Settings for crash reporting Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15693 ⁃ Settings for crash reporting FNX3-13597 ⁃ Settings for crash reporting Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13597 ⁃ Settings for crash reporting FNX-4711 ⁃ Settings for crash reporting Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-4711 ⁃ Settings for crash reporting FNX2-15693 ⁃ Settings for crash reporting Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-15693 ⁃ Settings for crash reporting Settings for crash reporting May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants