Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Tab crash page #1102

Open
lime124 opened this Issue Mar 20, 2019 · 23 comments

Comments

@lime124
Copy link

lime124 commented Mar 20, 2019

From Sawyer:

I noticed we do not have any UX for this. I'm happy to use a Focus-inspired crash page similar to the one found below, but we will need to make a couple changes:

  1. New copy for the description since we're saving history and not a private browser
  2. How "restoring" a session should look (likely a restore session button similar to close tab, with copy that reflects this)

There's also this question: #1003 (comment)

@lime124 lime124 added this to Backlog of upcoming work in Fenix MVP UX via automation Mar 20, 2019

@lime124 lime124 moved this from Backlog of upcoming work to In progress in Fenix MVP UX Mar 20, 2019

@brampitoyo brampitoyo changed the title [UX] crash reporting [UX] Tab crash page Mar 20, 2019

@brampitoyo

This comment has been minimized.

Copy link
Collaborator

brampitoyo commented Mar 20, 2019

Changed the issue name to reflect the fact that this error page appears only when a single tab has crashed – not when the whole app crashed.

@brampitoyo

This comment has been minimized.

Copy link
Collaborator

brampitoyo commented Mar 20, 2019

@sblatz Here’s a mockup for tab crashed page, along with copy that @mheubusch has written:

Inspectable mockup: https://mozilla.invisionapp.com/project/17050512

(Note that the illustration is still a placeholder, but the measurements are correct).

@brampitoyo brampitoyo moved this from In progress to Feedback from UX (general) in Fenix MVP UX Mar 20, 2019

@sblatz

This comment has been minimized.

Copy link
Contributor

sblatz commented Mar 21, 2019

@brampitoyo is <name> here the name of the user? If so, how will we know their name if they don't have an account?

(perhaps it's just "Fenix" in this case?)

@mheubusch

This comment has been minimized.

Copy link
Collaborator

mheubusch commented Mar 21, 2019

@sblatz

This comment has been minimized.

Copy link
Contributor

sblatz commented Mar 21, 2019

Thanks for the clarification, I also don't seem to have access to that placeholder image (even when I do inspect mode, there's no asset), are you able to send it to me? :)

@mheubusch

This comment has been minimized.

Copy link
Collaborator

mheubusch commented Mar 23, 2019

@sblatz did you get the asset you needed for restore tab? Also do you need a new user story/epic for restore session?

@lime124

This comment has been minimized.

Copy link
Author

lime124 commented Mar 23, 2019

@mheubusch sean got him all the error page illustrations and strings on friday.

@sv-ohorvath

This comment has been minimized.

Copy link

sv-ohorvath commented Mar 27, 2019

@mheubusch Hello, it might be just me, but the crash message sounds like the tab can't be restored, although there's still a "restore tab" option.

#2: There's no "send crash report" option in the tab crash reporter. Is that intentional?

@mheubusch

This comment has been minimized.

Copy link
Collaborator

mheubusch commented Mar 27, 2019

@sv-ohorvath not just you. :) Have someone on my team taking a fresh look at this - thank you. also, IICR we are handling crash reporting options in the settings, not at the page level but @brampitoyo can confirm.

@MeridelW

This comment has been minimized.

Copy link

MeridelW commented Mar 27, 2019

Hi @sv-ohorvath! That copy has indeed been updated (see attachment for latest mock—still a work in progress...for example, button copy should be all caps). The user can indeed "try again" and the copy no longer contradicts this.

As for "send crash report," there is a separate prompt that comes up in the flow for the user to report an issue. This is the only error that has the reporting function as this is the only error that is Mozilla's fault.
New content crash message

@sblatz

This comment has been minimized.

Copy link
Contributor

sblatz commented Mar 27, 2019

This page is currently being displayed when a tab crashes. GV team is working on a feature that would allow a tab to be restored after it has crashed, but right now we can only close it (or choose to reload the page without any history). I don't think a "try again" button being the only option is good, as it does not give a clear indication to the user that they may be forced to just close the tab to get out of the loop.

Do we want to change the behavior of "restore tab" to just reload the URL of the crashed tab with no history?

@MeridelW

This comment has been minimized.

Copy link

MeridelW commented Mar 27, 2019

@brampitoyo Can you weigh in on this? What's the best way to give the user the option to close the tab? I agree we need this.

@sblatz What are the implications of reloading with no history?

@sblatz

This comment has been minimized.

Copy link
Contributor

sblatz commented Mar 27, 2019

@MeridelW Essentially it would be like they had just started a brand new tab with that page loaded. This means their scroll position, any data entered, any previous history of browsing on that tab would be lost.

@MeridelW

This comment has been minimized.

Copy link

MeridelW commented Mar 27, 2019

@brampitoyo What are your thoughts on this?

@brampitoyo

This comment has been minimized.

Copy link
Collaborator

brampitoyo commented Mar 27, 2019

@sblatz @MeridelW In earlier mockup, we have options for “Close tab” and “Restore tab”. Shall we use those?

“Restore tab” would make sense only if we can ensure that the tab won’t crash again (and go into a reload-crash-error-reload-crash-error… loop). Otherwise, “Close tab” is a safer bet.

Would starting a brand new tab without saving anything help fix this loop?

@sblatz

This comment has been minimized.

Copy link
Contributor

sblatz commented Mar 27, 2019

@brampitoyo "Restore tab" could attempt to restore once, then would send us back to the same spot, but the user could then press "close tab". Keep in mind that this option is not yet available on the GeckoView side, so we could have "restore tab" just reload the tab's URL with no history, which, if it crashed again, would leave the user in a position to press "close tab" if they think they're in a loop.

@brampitoyo

This comment has been minimized.

Copy link
Collaborator

brampitoyo commented Mar 28, 2019

@sblatz OK. Let’s go with “Close tab” and “Restore tab”, then. This way, the user can try to recover (which is always a preferred option), and can close when recovery fails.

@brampitoyo

This comment has been minimized.

Copy link
Collaborator

brampitoyo commented Mar 28, 2019

@sblatz Please find the new tab crash design (the only change is the inclusion of two buttons: close and restore) here: https://mozilla.invisionapp.com/share/P7R8W1ZWHM6

@sblatz

This comment has been minimized.

Copy link
Contributor

sblatz commented Mar 28, 2019

@brampitoyo After some more work on this, it seems we actually don't have the ability to reload the tab just yet. I will just use a "close tab" button for now, and will add the "reload tab" when this functionality is added by the GV team

@vesta0 vesta0 added the UX label Apr 1, 2019

@vesta0 vesta0 added this to the MVP Backlog milestone Apr 1, 2019

@vesta0 vesta0 added the P1 label Apr 1, 2019

@brampitoyo

This comment has been minimized.

Copy link
Collaborator

brampitoyo commented Apr 4, 2019

@sblatz I’ve updated the mockup based on having only a “Close tab” button:

@brampitoyo

This comment has been minimized.

Copy link
Collaborator

brampitoyo commented Apr 17, 2019

Paging @shorlander to review the design above.

@mheubusch mheubusch moved this from Feedback from UX (general) to Design Review in Fenix MVP UX Apr 17, 2019

@shorlander

This comment has been minimized.

Copy link
Collaborator

shorlander commented Apr 18, 2019

Looks good to me.

@brampitoyo I don't know if we have illustrations in these pages yet, but Sean says we should use fx-fenix_error_9.svg for this.

@shorlander shorlander moved this from Design Review to Feedback from Eng in Fenix MVP UX Apr 18, 2019

@shorlander shorlander moved this from Feedback from Eng to Design Review in Fenix MVP UX Apr 18, 2019

@mheubusch mheubusch modified the milestones: UX Backlog, MVP Backlog Apr 18, 2019

@mheubusch

This comment has been minimized.

Copy link
Collaborator

mheubusch commented Apr 18, 2019

@sblatz just a reminder that the actual string is Sorry. can't load that page.

@mheubusch mheubusch moved this from Design Review to Done in Fenix MVP UX Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.