Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

"Follow device theme" no longer switches to Dark mode automatically #10036

Closed
Cheap-Skate opened this issue Apr 18, 2020 · 5 comments
Closed
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified

Comments

@Cheap-Skate
Copy link

Cheap-Skate commented Apr 18, 2020

Steps to reproduce

Set Customise > Follow device theme
Switch Android phone between Light and Dark mode (aka Night mode)

Expected behavior

Fenix switches to dark mode (it did this until a week or two ago)

Actual behavior

No switch (this new broken behaviour started perhaps 2 weeks ago)

Device information

Galaxy A40, Android 10, today's Fenix Nightly

┆Issue is synchronized with this Jira Task

@Cheap-Skate Cheap-Skate added the 🐞 bug Crashes, Something isn't working, .. label Apr 18, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 18, 2020
@ghost
Copy link

ghost commented Apr 18, 2020

Yes, this happens on my device too. The dark mode or the light mode don't automatically switch when the dark mode is enabled or disabled System-wide.

Device: Motorola One Power, Android 10.

Fenix Build: Firefox Preview 4.3.0 (Build #21082025)
And
The today's Nightly

@umerf52
Copy link

umerf52 commented Apr 18, 2020

I'm also facing this bug.
OnePlus 3T, Android 10 (LOS 17.1, 20200401)
org.mozilla.fenix.nightly, Nightly 200416 08:30

It's daytime (1:40pm) right now, so everything is in light mode
In Phone Settings > Display > Dark Theme = Will turn on automatically at sunset
Fenix is set to follow system theme, but it is currently following light theme.
All other apps that are supposed to follow light mode are in light theme, e.g. Slack etc

@ygretharekar
Copy link

Hello I am able to reproduce the bug on my device, I would like to work on the solution, thanks.

@ekager ekager self-assigned this Apr 21, 2020
ekager added a commit to ekager/fenix that referenced this issue Apr 21, 2020
@ekager
Copy link
Contributor

ekager commented Apr 21, 2020

Thanks for bringing this to my attention! I found a fix and should be working after #10074 lands.

@ekager ekager added this to In Progress in Fenix Sprint Kanban Apr 21, 2020
@ekager ekager removed the needs:triage Issue needs triage label Apr 21, 2020
@ekager ekager moved this from In Progress to In Dev Review in Fenix Sprint Kanban Apr 21, 2020
@ekager ekager added the eng:qa:needed QA Needed label Apr 22, 2020
@sflorean
Copy link
Contributor

Verified as fixed on Nightly 04/23. Devices: Samsung Galaxy Note10 (Android 10) and Xiaomi Redmi Note 8T (Android 9).

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 23, 2020
@vesta0 vesta0 moved this from In Dev Review to Sprint 20.8 Done in Fenix Sprint Kanban Apr 28, 2020
@liuche liuche mentioned this issue Apr 28, 2020
32 tasks
@data-sync-user data-sync-user changed the title "Follow device theme" no longer switches to Dark mode automatically FNX2-15695 ⁃ "Follow device theme" no longer switches to Dark mode automatically Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15695 ⁃ "Follow device theme" no longer switches to Dark mode automatically FNX3-13600 ⁃ "Follow device theme" no longer switches to Dark mode automatically Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13600 ⁃ "Follow device theme" no longer switches to Dark mode automatically FNX-3243 ⁃ "Follow device theme" no longer switches to Dark mode automatically Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-3243 ⁃ "Follow device theme" no longer switches to Dark mode automatically FNX2-15695 ⁃ "Follow device theme" no longer switches to Dark mode automatically Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-15695 ⁃ "Follow device theme" no longer switches to Dark mode automatically "Follow device theme" no longer switches to Dark mode automatically May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Development

No branches or pull requests

6 participants