Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #10036 - Workaround for System Theme changes with config change #10074

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Apr 21, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

Codecov Report

Merging #10074 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10074   +/-   ##
=========================================
  Coverage     19.26%   19.27%           
  Complexity      532      532           
=========================================
  Files           340      340           
  Lines         13790    13792    +2     
  Branches       1847     1847           
=========================================
+ Hits           2657     2658    +1     
- Misses        10895    10896    +1     
  Partials        238      238           
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 12.24% <0.00%> (-0.17%) 4.00 <0.00> (ø)
...ix/home/sessioncontrol/SessionControlController.kt 72.72% <0.00%> (+0.90%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d51c4f...6e34e00. Read the comment docs.

@ekager
Copy link
Contributor Author

ekager commented Apr 22, 2020

I tested this and locales still switch immediately. 👍

@ekager ekager requested a review from boek April 22, 2020 02:36
Copy link
Contributor

@mcarare mcarare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ekager ekager merged commit 70755ad into mozilla-mobile:master Apr 22, 2020
@ekager ekager deleted the theme-config branch April 22, 2020 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants