Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Edit logins - duplicates and save criteria #10173

Closed
4 tasks done
eliserichards opened this issue Apr 24, 2020 · 7 comments
Closed
4 tasks done

Edit logins - duplicates and save criteria #10173

eliserichards opened this issue Apr 24, 2020 · 7 comments
Labels
E3 Estimation Point: average, 2 - 3 days Feature:Logins
Projects
Fenix Q2 Feature Backlog Fenix Product Backlog Fenix Sprint Kanban

Comments

@eliserichards
Copy link
Contributor

eliserichards commented Apr 24, 2020 •
edited by data-sync-user
Loading

Acceptance Criteria

  • disallow duplicate usernames - getPotentialDupesIgnoringUsername(login) in SyncableLoginsStorage
  • disallow save when password is empty OR dupe is detected
    • gray out save button
    • button is non-clickable

┆Issue is synchronized with this Jira Task
@eliserichards eliserichards added E3 Estimation Point: average, 2 - 3 days Feature:Logins labels Apr 24, 2020
@eliserichards eliserichards added this to Differentiate through privacy in Fenix Q2 Feature Backlog Apr 24, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 24, 2020
@eliserichards eliserichards removed the needs:triage Issue needs triage label Apr 24, 2020
@eliserichards eliserichards mentioned this issue Apr 24, 2020
Merged
10 tasks
@vesta0 vesta0 added this to Q2: Fenix in Fenix Product Backlog May 12, 2020
@eliserichards eliserichards mentioned this issue May 12, 2020
Closed
@eliserichards eliserichards added this to Prioritized Backlog in Fenix Sprint Kanban May 14, 2020
@liuche liuche moved this from Prioritized Backlog to Inbox in Fenix Sprint Kanban May 14, 2020
@eliserichards eliserichards moved this from Inbox to In Progress in Fenix Sprint Kanban May 15, 2020
@eliserichards eliserichards self-assigned this May 15, 2020
This was referenced May 21, 2020
Closed
Closed
@eliserichards eliserichards mentioned this issue Jun 3, 2020
Merged
4 tasks
@liuche liuche mentioned this issue Jun 5, 2020
Closed
4 tasks
@eliserichards eliserichards mentioned this issue Jun 9, 2020
Merged
4 tasks
@eliserichards
Copy link
Contributor Author

Related to #10172 - that PR should be merged before this can be merged.

This was referenced Jun 10, 2020
Closed
Merged
@liuche
Copy link
Contributor

liuche commented Jun 18, 2020

Hey @eliserichards how is this going? I want to get this into Nightly for testing early, or else we should just skip Release and do a fast-follow.

@liuche liuche moved this from In Progress to Inbox in Fenix Sprint Kanban Jun 22, 2020
@vesta0 vesta0 moved this from Inbox to Feature Backlog in Fenix Sprint Kanban Jun 26, 2020
eliserichards added a commit that referenced this issue Jul 16, 2020
@eliserichards
For #10173: login duplicates and save (#11208)
023a498 
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
@eliserichards
Copy link
Contributor Author

For QA

There are still a few bugs with this depending on the next nightly build of AC (#12651)

@eliserichards eliserichards added the eng:qa:needed QA Needed label Jul 16, 2020
@project-bot project-bot bot moved this from Feature Backlog to Ready for QA in Fenix Sprint Kanban Jul 16, 2020
@lobontiumira
Copy link

This is not fixed yet.
Tested on the 7/20 Nightly build with Samsung Galaxy Tab S6 (Android 9), and Sony Xperia Z5 Premium (Android 7.1.1).
I was able to save the same password on the same page, following these STR:

  1. Go to twitter.com, fill in valid credentials, save them.
  2. Verify that the credentials are saved in Logins and passwords.
  3. In Logins and passwords, disable the Autofill option.
  4. Go to Settings - Delete browsing data, check only Cookies and tap on the Delete browsing data.
  5. Close Fenix.
  6. Reopen Fenix, and go to the twitter.com page and refill the credentials from step 2.
  7. The Save prompt is displayed again and the credentials are saved again - duplicate.

@lobontiumira lobontiumira removed the eng:qa:needed QA Needed label Jul 20, 2020
@eliserichards
Copy link
Contributor Author

That is a bug with Save and Autofilling credentials. I will file that as a separate ticket. This issue is only applicable for editing a saved login.

@eliserichards eliserichards mentioned this issue Jul 20, 2020
Closed
@liuche liuche mentioned this issue Jul 20, 2020
Closed
9 tasks
@lobontiumira
Copy link

Hi @eliserichards,

I've tested again on Beta 80.0.0-beta.1, and on the 7/30 Nightly build with Samsung Galaxy Tab S6 (Android 9), with twitter.com account.

Using the following STR:

  1. Go to twitter.com and sign in with valid credentials.
  2. When asked to save the credentials, tap on "Save".
  3. Log out from twitter.com.
  4. Delete the auto-filled credentials.
  5. Sign in again on twitter.com, with the same credentials.

Actual results:
The prompt is displayed again, The user can save again the same credentials. Fenix doesn't recognize the duplicate. There is no grayed out "Save" button (non-clickable).

@ekager
Copy link
Contributor

ekager commented Aug 1, 2020

Thanks @softvision-miralobontiu - we pulled those STR into #12751

@ekager ekager closed this as completed Aug 1, 2020
Fenix Sprint Kanban automation moved this from Ready for QA to Sprint 20.11 Done Aug 1, 2020
@data-sync-user data-sync-user changed the title Edit logins - duplicates and save criteria FNX3-13700 ⁃ Edit logins - duplicates and save criteria Aug 10, 2020
Fenix Sprint Kanban automation moved this from Sprint 20.11 Done to In Progress Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13700 ⁃ Edit logins - duplicates and save criteria FNX-3334 ⁃ Edit logins - duplicates and save criteria Aug 10, 2020
@liuche liuche closed this as completed Aug 10, 2020
Fenix Sprint Kanban automation moved this from In Progress to Sprint 20.11 Done Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-3334 ⁃ Edit logins - duplicates and save criteria FNX2-13088 ⁃ Edit logins - duplicates and save criteria Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-13088 ⁃ Edit logins - duplicates and save criteria Edit logins - duplicates and save criteria May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
E3 Estimation Point: average, 2 - 3 days Feature:Logins
Projects
Fenix Product Backlog
Q2
Fenix Sprint Kanban
  
Sprint 20.11 Done
Fenix Q2 Feature Backlog
Differentiate through privacy
Milestone
No milestone
Development

No branches or pull requests
5 participants
@liuche @ekager @lobontiumira @eliserichards @data-sync-user