Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Allow users to manually re-order tabs #10344

Closed
vesta0 opened this issue May 1, 2020 · 61 comments · Fixed by #27637, fork-house/fenix#14, Leland-Takamine/fenix#159 or nathanmkaya/fenix#108
Closed
Assignees
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Tabs pin Issues, features, improvements that are still valid
Milestone

Comments

@vesta0
Copy link
Collaborator

vesta0 commented May 1, 2020

User Story

As a user with a lot of open tabs, I want to be able to easily locate the last tab I was on and re-order tabs in a way that fits my needs, so I don't have to spend time looking for a specific tab.

Acceptance Criteria

  • I can easily find and open the last tab I was on
  • I can easily re-order tabs to where I want them to be

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added this to Triage in Tabs Tray May 1, 2020
@vesta0 vesta0 added feature request 🌟 New functionality and improvements Skittle labels May 1, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 1, 2020
@vesta0 vesta0 added the P2 Upcoming release label May 13, 2020
@ekager
Copy link
Contributor

ekager commented May 14, 2020

Relevant - adding lastUsed field to Tabs in AC: mozilla-mobile/android-components#5178
We are going to be working on this very soon as part of Sync Tab work

@ekager ekager removed the needs:triage Issue needs triage label May 14, 2020
@vesta0 vesta0 changed the title Access most recently opened tab Easily identify the most recently opened tab May 14, 2020
@liuche liuche changed the title Easily identify the most recently opened tab UX: Easily identify the most recently opened tab May 14, 2020
@liuche
Copy link
Contributor

liuche commented May 14, 2020

Currently we put the most recent tabs on bottom, highlight the current tab, and will scroll to tab.

@vesta0 vesta0 changed the title UX: Easily identify the most recently opened tab UX: Easily find the most recently opened tab when I have many tabs open May 14, 2020
@yoasif
Copy link
Contributor

yoasif commented May 14, 2020

Currently we put the most recent tabs on bottom, highlight the current tab, and will scroll to tab.

This matches desktop, but I use https://addons.mozilla.org/firefox/addon/always-right/ (browser.tabs.insertAfterCurrent:true) to get tabs adjacent to the position I am at when opening a new tab.

Fenix already opens tabs in an adjacent position when opening a new tab from an existing tab (spawning a tab). I think it would be nice to have the behavior of browser.tabs.insertAfterCurrent:true in Fenix by default.

It also makes more sense with gestures - imagine if a user swipes left on a tab and doesn't find the tab that they just came from (by opening a new tab).

Seems like that is also filed here: #10365

@topotropic topotropic moved this from Triage to Backlog in Tabs Tray Jun 1, 2020
@liuche liuche changed the title UX: Easily find the most recently opened tab when I have many tabs open UX: Tab organization Jun 4, 2020
@liuche
Copy link
Contributor

liuche commented Jun 4, 2020

We've done this for MVP, but we'll need to talk about how to handle the different paradigms of: self-ordered tabs vs recent tabs

@liuche liuche removed this from Backlog in Tabs Tray Jun 4, 2020
@vesta0 vesta0 added this to Q3 Backlog in Fenix Product Backlog Jun 4, 2020
@vesta0 vesta0 removed feature request 🌟 New functionality and improvements P2 Upcoming release labels Jun 15, 2020
@vesta0 vesta0 added this to Triage in Tabs Tray via automation Jun 15, 2020
@vesta0 vesta0 moved this from Triage to Backlog in Tabs Tray Jun 15, 2020
@vesta0 vesta0 changed the title UX: Tab organization [Meta] Tab organization Jun 16, 2020
@vesta0 vesta0 moved this from Backlog to Stories in Tabs Tray Jun 29, 2020
@vesta0 vesta0 removed this from Stories in Tabs Tray Jun 29, 2020
@data-sync-user data-sync-user changed the title [Meta] Tab organization FNX-3449 ⁃ [UX] Tab organization Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX-3449 ⁃ [UX] Tab organization FNX3-13825 ⁃ [Meta] Tab organization Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13825 ⁃ [Meta] Tab organization FNX-3449 ⁃ [UX] Tab organization Aug 11, 2020
DreVla added a commit to DreVla/fenix that referenced this issue Nov 1, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 1, 2022
Mugurell pushed a commit to DreVla/fenix that referenced this issue Nov 1, 2022
@github-actions github-actions bot mentioned this issue Nov 1, 2022
4 tasks
@mergify mergify bot closed this as completed in #27637 Nov 1, 2022
@github-actions github-actions bot reopened this Nov 1, 2022
@github-actions github-actions bot added this to the 108 milestone Nov 1, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Nov 1, 2022
@Dakkaron
Copy link

Dakkaron commented Nov 1, 2022

This feature is enabled in nightly already. We have a product decision to enable it in beta and release also.

Does this mean tab reordering is coming back to the main andoird firefox app? I left a comment here months ago explaining my frustration and that I am not super tech savvy so I am unfamiliar with the lingo.

Any guarantee and timeline?

Thank you.

Disclaimer: Not a Mozilla employee here.

They just pushed a change that removes the feature toggle which, up until now, prevented the feature from showing up in the beta and release (which is the "real") versions. Since this is removed, the feature should show up in the next release of FF.

The next release is scheduled for the 15th of November.

Again, take everything with a pinch of salt, since I am not a Mozilla employee, I know only what I can see publically.

@cadeyrn
Copy link
Contributor

cadeyrn commented Nov 1, 2022

Since this is removed, the feature should show up in the next release of FF.

The next release is scheduled for the 15th of November.

Assuming it will ride the trains it will be in Firefox 108 Beta and then Firefox 108, not in the stable release of Firefox 107 that will be released in November. Firefox 108 is on schedule for the 13th of December.

@SoftVision-LorandJanos
Copy link

There is no "Sort open tabs" section in the tab settings in the latest Nightly 108.0a1 (2022-11-03).
Will recheck later.

@Mugurell
Copy link
Contributor

Mugurell commented Nov 3, 2022

There is no "Sort open tabs" section in the tab settings in the latest Nightly 108.0a1 (2022-11-03). Will recheck later.

The feature ended up having no setting.
There is no automatic functionality, users can do the "long press and drag tabs to reorder" gesture or not.
This was already enabled in Nightly, the recent patch enabled the feature in beta and release also starting with version 108.

@SoftVision-LorandJanos
Copy link

With this new information, I can confirm that the tabs can be manually rearranged by "long press and drag" in the latest Nightly 108.0a1 (2022-11-03).
Device used: Oppo Find X5 (Android 12).
Closing the ticket as verified.

@SoftVision-LorandJanos
Copy link

Verified as fixed on the latest Beta 108.0b1.
Device used: Google Pixel 4 (Android 13).

@MasterInQuestion
Copy link

    Not possible for private tabs.

@Jorengarenar
Copy link

@MasterInQuestion I think you may need to create new issue for that

@MasterInQuestion
Copy link

    Creating a new Issue for one essentially identical?..

@Jorengarenar
Copy link

Creating a new Issue for one essentially identical?..

This one ain't gonna reopen itself and nobody gonna rebase the repo to change commit messages to undo "fixed by".
So yes, this feature request is complete. If you wanna have the bug fixed, report it.

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.