Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Tab Tray] Show longer titles (on 2 rows)..., to match current Fenix Home Screen #10683

Closed
klint opened this issue May 15, 2020 · 12 comments
Closed
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs

Comments

@klint
Copy link

klint commented May 15, 2020

Steps to reproduce

Activate new Tab Tray secret setting
Open some sites to feed the Tab Tray 😀
Move to Tab Tray

Expected behavior

Titles displayed for sites should be long enough to be meaningful (note that I don't rely on Site Previews where the expected information could not present/readable).
IMHO, the current Fenix Home Page as shown below shows a good example of what the information density should be:

  • number of rows (2 rows for the title), space between rows
  • font size & color (contrast) differences between titles and URLs.

image

Actual behavior

Titles displayed for sites are truncated on 1 row each, therefore they are not meaningful at all, as you can see below (same sites as above, in reverse order)

image

Device information

  • Android device: 9
  • Fenix version: build #2015740403

Thank you and pardon my French 😉

┆Issue is synchronized with this Jira Task

@klint klint added the 🐞 bug Crashes, Something isn't working, .. label May 15, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 15, 2020
@klint klint changed the title [Tab Tray] Show longer titles (on 2 rows), to match current Fenix Home Screen [Tab Tray] Show longer titles (on 2 rows)..., to match current Fenix Home Screen May 15, 2020
@ekager ekager added needs:UX-feedback Needs UX Feedback and removed needs:triage Issue needs triage labels May 16, 2020
@ekager ekager added this to Triage in Tabs Tray May 18, 2020
@brampitoyo
Copy link

@topotropic Do you have any comment or opinion around longer titles on tab names?

For reference, here are examples of other browsers that display the tab’s page name and URLs in a list view:

Samsung Internet

UC Mini

Yandex Browser

@klint
Copy link
Author

klint commented May 19, 2020

For the sake of good comparison, I have updated the initial screenshots to match the sites on the other browsers's examples.
(I hope this help clarify how useful the 3 lines (2 for the title + 1 for the URL) in the current/old Fenix home page can be... Site previews vs favicons debate put aside, of course). Thanks

@yoasif
Copy link
Contributor

yoasif commented May 19, 2020

Not really sure about three lines, but two lines is definitely an improvement over the current tab tray.

@klint
Copy link
Author

klint commented May 19, 2020

Sorry I meant 3 lines including the url itself 😉

@klint
Copy link
Author

klint commented Jun 18, 2020

Back on this issue to stress the need of solving it, now that we can have a good experience of site previews in the nightly builds :)
As you can see from the Screenshots below, taken in both light and dark modes, the site previews are not sufficient on their own to easily identify tabs (particularly with numerous tabs in the list. I have 99+).
image

@AmyYLee
Copy link
Collaborator

AmyYLee commented Jun 24, 2020

@topotropic for follow-up

@AmyYLee
Copy link
Collaborator

AmyYLee commented Jul 10, 2020

@betsymi @topotropic for follow-up

@topotropic topotropic added needs:UX-investigation Issues where UX needs to define or scope a solution or determine feasibility and removed needs:UX-feedback Needs UX Feedback labels Jul 15, 2020
dglttr added a commit to dglttr/fenix that referenced this issue Jul 17, 2020
@data-sync-user data-sync-user changed the title [Tab Tray] Show longer titles (on 2 rows)..., to match current Fenix Home Screen FNX3-14074 ⁃ [Tab Tray] Show longer titles (on 2 rows)..., to match current Fenix Home Screen Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14074 ⁃ [Tab Tray] Show longer titles (on 2 rows)..., to match current Fenix Home Screen FNX-4468 ⁃ [Tab Tray] Show longer titles (on 2 rows)..., to match current Fenix Home Screen Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4468 ⁃ [Tab Tray] Show longer titles (on 2 rows)..., to match current Fenix Home Screen FNX2-13233 ⁃ [Tab Tray] Show longer titles (on 2 rows)..., to match current Fenix Home Screen Aug 11, 2020
@klint
Copy link
Author

klint commented Aug 24, 2020

Following the PR for issue #11918 moved to nightly recently, it seems that the screenshots shown in the Tab Tray are now reflecting the current screen view of the page when the Tab Tray button was pressed, instead of the top of the page itself (maybe I'm wrong, but I think that before, the tops of pages would be shown in the Tab Tray). Which makes the pages less recognizable in the Tab Tray imho (the often proeminent title on the top the page being absent from the picture).
That is one more reason for displaying a longer and more explicit title :).
Note that this has also been requested on some comments on Google Play.

@kbrosnan kbrosnan changed the title FNX2-13233 ⁃ [Tab Tray] Show longer titles (on 2 rows)..., to match current Fenix Home Screen [Tab Tray] Show longer titles (on 2 rows)..., to match current Fenix Home Screen Aug 29, 2020
@liuche liuche added this to Inbox in Engineering triage via automation Sep 2, 2020
@liuche liuche moved this from Inbox to Skittle Staging Backlog in Engineering triage Sep 2, 2020
@vesta0 vesta0 removed this from Triage in Tabs Tray Oct 12, 2020
@topotropic topotropic removed the needs:UX-investigation Issues where UX needs to define or scope a solution or determine feasibility label Oct 13, 2020
@topotropic topotropic removed their assignment Oct 13, 2020
dglttr added a commit to dglttr/fenix that referenced this issue Oct 14, 2020
Also update tab tray item layout according to specs posted in the issue.
dglttr added a commit to dglttr/fenix that referenced this issue Oct 14, 2020
Also update tab tray item layout according to specs posted in the issue.
dglttr added a commit to dglttr/fenix that referenced this issue Oct 14, 2020
Also update tab tray item layout according to specs posted in the issue.
@cadeyrn
Copy link
Contributor

cadeyrn commented Oct 14, 2020

@topotropic Is it really necessary to have such a large gap between title and URL if the title has only one line? As I first saw the screenshot in the pull request for this issue I thought it's a bug in the implementation. I would expect that the spacing between the title and the URL doesn't depened on the number of lines for the title. The whole should be vertically centered so that it always looks good. What do you think?

dglttr added a commit to dglttr/fenix that referenced this issue Oct 14, 2020
Also update tab tray item layout according to specs posted in the issue.
bors bot pushed a commit that referenced this issue Oct 14, 2020
15886: For #10683: Show longer tab titles r=mcarare a=amkcpu

Also update tab tray item layout according to specs posted in the issue.
cc @mcarare because you reviewed the previous PR (#12684).

<img src="https://user-images.githubusercontent.com/46764284/96002370-55c79500-0e39-11eb-9abb-cd5ac901d687.png" width=300 />


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features. In addition, it includes a screenshot of a successful [accessibility scan](https://play.google.com/store/apps/details?id=com.google.android.apps.accessibility.auditor&hl=en_US) to ensure no new defects are added to the product.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture


Co-authored-by: amkcpu <amkcpu@outlook.com>
mcarare pushed a commit to dglttr/fenix that referenced this issue Oct 14, 2020
Also update tab tray item layout according to specs posted in the issue.
@topotropic
Copy link

@topotropic Is it really necessary to have such a large gap between title and URL if the title has only one line? As I first saw the screenshot in the pull request for this issue I thought it's a bug in the implementation. I would expect that the spacing between the title and the URL doesn't depened on the number of lines for the title. The whole should be vertically centered so that it always looks good. What do you think?

Thanks for your feedback. The assumption is that most sites have longer titles and the 1-liner will be a rare case (I'll keep an eye on that). And another point is to keep things starting in the same place for better scan-ability, so all titles have the same top margin, instead of aligning them to the URL.

@topotropic
Copy link

Ok, I tested it on various screen sizes and realized quickly that the assumption that most titles will span over two lines doesn't hold true. Thanks for the pointer @cadeyrn

And apologies to this oversight @amkcpu – I'd appreciate it if you could update the implemented design to match the following (so center title and domain with 4dp spacing between them):

image

Thank you!

dglttr added a commit to dglttr/fenix that referenced this issue Oct 16, 2020
Also update tab tray item layout according to specs posted in the issue.
mcarare pushed a commit that referenced this issue Oct 16, 2020
Also update tab tray item layout according to specs posted in the issue.
@mcarare mcarare added the eng:qa:needed QA Needed label Oct 16, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Oct 19, 2020

Hi, verified as fixed on the latest Nightly 201019 build using the following devices:
• Google Pixel 3a (Android 11)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

►Screenshot
rsz_3screenshot_20201019-115554

@AndiAJ AndiAJ closed this as completed Oct 19, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Oct 19, 2020
@liuche liuche removed this from Skittle Staging Backlog in Engineering triage Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs
Development

Successfully merging a pull request may close this issue.

10 participants