"Open all..." option (Synced tabs, Bookmark Folder, etc) #11404

yoasif · 2020-06-09T22:55:43Z

What is the user problem or growth opportunity you want to see solved?

Users should be able to open all of their synced tabs in Fenix in order to quickly restore a session from another device.

How do you know that this problem exists today? Why is this important?

My Pixel is getting replaced due to a hardware issue. I want to maintain my user data from my previous device, and #2080 is not yet a feature. Google restores also don't restore my session from the cloud.

The closest feature to restore my tabs from my old device is sync, but it is extremely cumbersome to tap 3 times for every tab I want to migrate. I have over 100 tabs in my old device, so that at a minimum, 300 taps on my screen along with the sheer inefficiency of the process.

Who will benefit from it?

Anyone who wants to migrate their existing session to a new device.

┆Issue is synchronized with this Jira Task

liuche · 2020-06-10T14:30:39Z

Maybe something in this context menu:

- Create element to be displayed - Update the interface and bind in the view holder Set the filter to limit this action to FOLDER. - Create core function Main logic is done on the controller (has it should be done). The whole process is done in one coroutine to be non-blocking as many (sub)folders & links can be present. If folder is empty, a toast is displayed. Else iterate on items. When item is: - a FOLDER -> restart process (without toast) on the folder - a ITEM -> open it - a SEPARATOR -> do nothing Once finished, show the tabs tray. Toast message is defined in fragment to have access to context. - Create androidTest for openAllInTabs - Create tests for handleBookmarkFolderOpening - Display 'open all' options only if folder has at least on child: A coroutine and suspended functions have to be used, since `getTree` is async.

Expiration date is set to the same of others bookmark metrics.

#21212 (comment) - Add option is tree dot menu - Edit folder opening to be aware of browsing mode - Add metrics - Add unit tests for 'Open all in private tabs' - Add Android tests for open all in private.

Current threshold is 15.

Specify Firefox will only slow down while pages are loading.

…ring

LaurentiuApahideanSV · 2022-09-21T14:54:15Z

I tested the issue on Firefox Nightly 107.0a1 (2022-09-21) and the option to open all tabs from a bookmarks folder is present and functioning correctly. Additionally a message is displayed when trying to open 15 or more tabs at once.

Devices used:

Google Pixel 6 (Android 13)
Samsung Galaxy S22 Ultra (Android 12)

* Add "Open all in new tabs" options in bookmarks * Add "Open all in private tabs" options in bookmarks * Add metrics tracking if the usage of "Open all in..." in bookmarks Co-authored-by: Pg <pg.developper.fr@gmail.com>

AdinaPetridean · 2022-10-27T06:53:43Z

Verified as fixed on Nightly 108.0a1 from 10/27 with OnePlus 9 Pro (Android 12). "Open all in new tabs" and "Open all in private tabs" options are displayed in Bookmark folders menu.

SoftVision-LorandJanos · 2022-11-15T07:46:08Z

Verified as fixed on the latest Beta 108.0b1.
Device used: Google Pixel 4 (Android 13).

- Create element to be displayed - Update the interface and bind in the view holder Set the filter to limit this action to FOLDER. - Create core function Main logic is done on the controller (has it should be done). The whole process is done in one coroutine to be non-blocking as many (sub)folders & links can be present. If folder is empty, a toast is displayed. Else iterate on items. When item is: - a FOLDER -> restart process (without toast) on the folder - a ITEM -> open it - a SEPARATOR -> do nothing Once finished, show the tabs tray. Toast message is defined in fragment to have access to context. - Create androidTest for openAllInTabs - Create tests for handleBookmarkFolderOpening - Display 'open all' options only if folder has at least on child: A coroutine and suspended functions have to be used, since `getTree` is async.

…abs metric in Glean Expiration date is set to the same of others bookmark metrics.

…s' option as requested. mozilla-mobile/fenix#21212 (comment) - Add option is tree dot menu - Edit folder opening to be aware of browsing mode - Add metrics - Add unit tests for 'Open all in private tabs' - Add Android tests for open all in private.

…lot of tabs are to be opened. Current threshold is 15.

… message Specify Firefox will only slow down while pages are loading.

…ests pending compose refactoring

…kmarks tests pending compose refactoring" This reverts commit f89aa29.

… warning message" This reverts commit 6fe7081.

… when a lot of tabs are to be opened." This reverts commit 8517fea.

…vate tabs' option as requested." This reverts commit 83ed1ab.

…in_new_tabs metric in Glean" This reverts commit d4a38b3.

…tion" This reverts commit ea926e8.

…okmarks * Add "Open all in new tabs" options in bookmarks * Add "Open all in private tabs" options in bookmarks * Add metrics tracking if the usage of "Open all in..." in bookmarks Co-authored-by: Pg <pg.developper.fr@gmail.com>

github-actions bot added the needs:triage Issue needs triage label Jun 9, 2020

This was referenced Jun 10, 2020

Add "open all" for bookmark folders #10878

Closed

Investigate Sync collections #6512

Closed

liuche changed the title ~~Open all synced tabs from a synced device~~ "Open all..." option (Synced tabs, Bookmark Folder, etc) Jun 10, 2020

liuche added feature request 🌟 New functionality and improvements Feature:Bookmarks Feature:SyncTabs Sync tabs and removed needs:triage Issue needs triage labels Jun 10, 2020

data-sync-user changed the title ~~"Open all..." option (Synced tabs, Bookmark Folder, etc)~~ FNX3-14611 ⁃ "Open all..." option (Synced tabs, Bookmark Folder, etc) Aug 10, 2020

data-sync-user changed the title ~~FNX3-14611 ⁃ "Open all..." option (Synced tabs, Bookmark Folder, etc)~~ FNX-12336 ⁃ "Open all..." option (Synced tabs, Bookmark Folder, etc) Aug 11, 2020

data-sync-user changed the title ~~FNX-12336 ⁃ "Open all..." option (Synced tabs, Bookmark Folder, etc)~~ FNX2-13450 ⁃ "Open all..." option (Synced tabs, Bookmark Folder, etc) Aug 11, 2020

kbrosnan changed the title ~~FNX2-13450 ⁃ "Open all..." option (Synced tabs, Bookmark Folder, etc)~~ "Open all..." option (Synced tabs, Bookmark Folder, etc) Aug 29, 2020

Taknok mentioned this issue Sep 9, 2021

For #11404 : "Open all..." option #21212

Merged

3 tasks

issue-dispenser mentioned this issue Sep 7, 2022

Synced Tabs: Allow opening multiple tabs in the background #15481

Closed

github-actions bot mentioned this issue Sep 19, 2022

For #11404 : "Open all..." option #26864

Closed

4 tasks

github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 19, 2022

rvandermeulen closed this as completed in #21212 Sep 19, 2022

rvandermeulen pushed a commit that referenced this issue Sep 19, 2022

For #11404 - Create the open_all_in_new_tabs metric in Glean

f1bd7e1

Expiration date is set to the same of others bookmark metrics.

rvandermeulen pushed a commit that referenced this issue Sep 19, 2022

For #11404 - Create alert message when a lot of tabs are to be opened.

c75e331

Current threshold is 15.

rvandermeulen pushed a commit that referenced this issue Sep 19, 2022

For #11404 - Update open all tabs warning message

b11fd91

Specify Firefox will only slow down while pages are loading.

rvandermeulen pushed a commit that referenced this issue Sep 19, 2022

For #11404 - Disable new open bookmarks tests pending compose refacto…

0d439f9

…ring

github-actions bot reopened this Sep 19, 2022

github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Sep 19, 2022

LaurentiuApahideanSV closed this as completed Sep 21, 2022

LaurentiuApahideanSV removed the eng:qa:needed QA Needed label Sep 21, 2022

github-actions bot mentioned this issue Oct 25, 2022

[pull] main from mozilla-mobile:main fork-house/fenix#13

Merged

mergify bot closed this as completed in #27138 Oct 26, 2022

github-actions bot added this to the 108 milestone Oct 26, 2022

github-actions bot reopened this Oct 26, 2022

github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Oct 26, 2022

AdinaPetridean closed this as completed Oct 27, 2022

AdinaPetridean removed the eng:qa:needed QA Needed label Oct 27, 2022

github-actions bot mentioned this issue Oct 28, 2022

[pull] main from mozilla-mobile:main nathanmkaya/fenix#108

Merged

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023

[fenix] For mozilla-mobile/fenix#11404 - Create the open_all_in_new_t…

d4a38b3

…abs metric in Glean Expiration date is set to the same of others bookmark metrics.

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023

[fenix] For mozilla-mobile/fenix#11404 - Create alert message when a …

8517fea

…lot of tabs are to be opened. Current threshold is 15.

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023

[fenix] For mozilla-mobile/fenix#11404 - Update open all tabs warning…

6fe7081

… message Specify Firefox will only slow down while pages are loading.

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023

[fenix] For mozilla-mobile/fenix#11404 - Disable new open bookmarks t…

f89aa29

…ests pending compose refactoring

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023

[fenix] Revert "For mozilla-mobile/fenix#11404 - Disable new open boo…

72fe438

…kmarks tests pending compose refactoring" This reverts commit f89aa29.

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023

[fenix] Revert "For mozilla-mobile/fenix#11404 - Update open all tabs…

41d0949

… warning message" This reverts commit 6fe7081.

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023

[fenix] Revert "For mozilla-mobile/fenix#11404 - Create alert message…

1070ddc

… when a lot of tabs are to be opened." This reverts commit 8517fea.

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023

[fenix] Revert "For mozilla-mobile/fenix#11404 - Add 'Open all in pri…

38a4ac6

…vate tabs' option as requested." This reverts commit 83ed1ab.

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023

[fenix] Revert "For mozilla-mobile/fenix#11404 - Create the open_all_…

31d961e

…in_new_tabs metric in Glean" This reverts commit d4a38b3.

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023

[fenix] Revert "For mozilla-mobile/fenix#11404 - Create open all func…

52a60fd

…tion" This reverts commit ea926e8.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"Open all..." option (Synced tabs, Bookmark Folder, etc) #11404

"Open all..." option (Synced tabs, Bookmark Folder, etc) #11404

yoasif commented Jun 9, 2020 •

edited by data-sync-user

Loading

liuche commented Jun 10, 2020

LaurentiuApahideanSV commented Sep 21, 2022

AdinaPetridean commented Oct 27, 2022

SoftVision-LorandJanos commented Nov 15, 2022

"Open all..." option (Synced tabs, Bookmark Folder, etc) #11404

"Open all..." option (Synced tabs, Bookmark Folder, etc) #11404

Comments

yoasif commented Jun 9, 2020 • edited by data-sync-user Loading

What is the user problem or growth opportunity you want to see solved?

How do you know that this problem exists today? Why is this important?

Who will benefit from it?

liuche commented Jun 10, 2020

LaurentiuApahideanSV commented Sep 21, 2022

Devices used:

AdinaPetridean commented Oct 27, 2022

SoftVision-LorandJanos commented Nov 15, 2022

yoasif commented Jun 9, 2020 •

edited by data-sync-user

Loading